c/b/supervised_user: Use range-based for where appropriate.

chrome/browser/supervised_user/supervised_user_service_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/path_service.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 117 matching lines @@
   supervised_user_service_->GetManualExceptionsForHost("www.example.com",
                                                        &exceptions);
   ASSERT_EQ(2u, exceptions.size());
   EXPECT_EQ(kExampleBarURL, exceptions[0]);
   EXPECT_EQ(kExampleFooURL, exceptions[1]);
 
   {
     DictionaryPrefUpdate update(profile_->GetPrefs(),
                                 prefs::kSupervisedUserManualURLs);
     base::DictionaryValue* dict = update.Get();
-    for (std::vector<GURL>::iterator it = exceptions.begin();
-         it != exceptions.end(); ++it) {
-      dict->RemoveWithoutPathExpansion(it->spec(), NULL);
-    }
+    for (const GURL& url : exceptions)
+      dict->RemoveWithoutPathExpansion(url.spec(), NULL);
   }
 
   EXPECT_EQ(SupervisedUserService::MANUAL_NONE,
             supervised_user_service_->GetManualBehaviorForURL(kExampleFooURL));
   EXPECT_EQ(SupervisedUserService::MANUAL_NONE,
             supervised_user_service_->GetManualBehaviorForURL(kExampleBarURL));
   EXPECT_EQ(SupervisedUserService::MANUAL_ALLOW,
             supervised_user_service_->GetManualBehaviorForURL(
                 kExampleFooNoWWWURL));
   EXPECT_EQ(SupervisedUserService::MANUAL_ALLOW,
@@ skipping 230 matching lines @@
   observer.Wait();
 
   site_lists = GetActiveSiteLists(supervised_user_service);
   ASSERT_EQ(2u, site_lists.size());
   sites.clear();
   site_lists[0]->GetSites(&sites);
   site_lists[1]->GetSites(&sites);
   ASSERT_EQ(4u, sites.size());
   // The site lists might be returned in any order, so we put them into a set.
   std::set<std::string> site_names;
-  for (std::vector<SupervisedUserSiteList::Site>::const_iterator it =
-      sites.begin(); it != sites.end(); ++it) {
-    site_names.insert(base::UTF16ToUTF8(it->name));
-  }
-  EXPECT_TRUE(site_names.count("YouTube") == 1u);
-  EXPECT_TRUE(site_names.count("Homestar Runner") == 1u);
-  EXPECT_TRUE(site_names.count(std::string()) == 1u);
-  EXPECT_TRUE(site_names.count("Moose") == 1u);
+  for (const SupervisedUserSiteList::Site& site : sites)
+    site_names.insert(base::UTF16ToUTF8(site.name));
+  EXPECT_EQ(1u, site_names.count("YouTube"));
+  EXPECT_EQ(1u, site_names.count("Homestar Runner"));
+  EXPECT_EQ(1u, site_names.count(std::string()));
+  EXPECT_EQ(1u, site_names.count("Moose"));
 
   EXPECT_EQ(SupervisedUserURLFilter::ALLOW,
             url_filter->GetFilteringBehaviorForURL(example_url));
   EXPECT_EQ(SupervisedUserURLFilter::ALLOW,
             url_filter->GetFilteringBehaviorForURL(moose_url));
 
   // Disable the first content pack.
   service_->DisableExtension(extension->id(),
                              extensions::Extension::DISABLE_USER_ACTION);
   observer.Wait();
 
   site_lists = GetActiveSiteLists(supervised_user_service);
   ASSERT_EQ(1u, site_lists.size());
   sites.clear();
   site_lists[0]->GetSites(&sites);
   ASSERT_EQ(1u, sites.size());
   EXPECT_EQ(base::ASCIIToUTF16("Moose"), sites[0].name);
 
   EXPECT_EQ(SupervisedUserURLFilter::WARN,
             url_filter->GetFilteringBehaviorForURL(example_url));
   EXPECT_EQ(SupervisedUserURLFilter::ALLOW,
             url_filter->GetFilteringBehaviorForURL(moose_url));
 }
 #endif  // !defined(OS_ANDROID)