[Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

components/password_manager/core/browser/password_form_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/password_manager/core/browser/password_form_manager.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/metrics/histogram.h"
@@ skipping 692 matching lines @@
   // to cut down on false positives. Specifically a site may have multiple login
   // forms with different markup, which might look similar to a signup form.
   if (pending.times_used == 1) {
     FormStructure pending_structure(pending.form_data);
     FormStructure observed_structure(observed.form_data);
     // Ignore |pending_structure| if its FormData has no fields. This is to
     // weed out those credentials that were saved before FormData was added
     // to PasswordForm. Even without this check, these FormStructure's won't
     // be uploaded, but it makes it hard to see if we are encountering
     // unexpected errors.
-    if (!pending.form_data.fields.empty() &&
+    if (!pending.form_data.password.name.empty() &&

[vabr (Chromium), 2014/10/13 12:30:53]

This seems like a change in behaviour -- what about checking that the username
element is also not present?

[Pritam Nikam, 2014/10/16 12:55:13]

Done.

         pending_structure.FormSignature() !=
             observed_structure.FormSignature()) {
       UploadPasswordForm(pending.form_data,
                          autofill::ACCOUNT_CREATION_PASSWORD);
     }
   }
 }
 
 void PasswordFormManager::UploadPasswordForm(
     const autofill::FormData& form_data,
@@ skipping 71 matching lines @@
     LogPasswordGenerationSubmissionEvent(PASSWORD_SUBMITTED);
 }
 
 void PasswordFormManager::SubmitFailed() {
   submit_result_ = kSubmitResultFailed;
   if (has_generated_password_)
     LogPasswordGenerationSubmissionEvent(PASSWORD_SUBMISSION_FAILED);
 }
 
 }  // namespace password_manager