components/password_manager/core/browser/password_autofill_manager_unittest.cc - Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager_unittest.cc

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review inputs. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/password_form_fill_data.cc ('K') | « components/password_manager/core/browser/password_autofill_manager.cc ('k') | components/password_manager/core/browser/password_form_manager.cc » ('j') | components/password_manager/core/browser/password_form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_autofill_manager_unittest.cc b/components/password_manager/core/browser/password_autofill_manager_unittest.cc

index 3440764024dda3bffb35e45149135515f8cbc791..6e8c79b26af79b71b2a351092fbd4cb46f380e7b 100644

--- a/components/password_manager/core/browser/password_autofill_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_autofill_manager_unittest.cc

@@ -76,12 +76,12 @@ class PasswordAutofillManagerTest : public testing::Test {

// Add a preferred login and an additional login to the FillData.

username_field_.name = base::ASCIIToUTF16(kUsernameName);

username_field_.value = test_username_;

- fill_data_.basic_data.fields.push_back(username_field_);

+ fill_data_.basic_data.username = username_field_;

autofill::FormFieldData password_field;

password_field.name = base::ASCIIToUTF16(kPasswordName);

password_field.value = test_password_;

- fill_data_.basic_data.fields.push_back(password_field);

+ fill_data_.basic_data.password = password_field;

}

void InitializePasswordAutofillManager(