Issue 631963005: remove OVERRIDE macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 631963005: remove OVERRIDE macro (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore

Modified:
6 years, 2 months ago

Reviewers:
danakj, dcheng

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

remove OVERRIDE macro Now that we have removed all usage of the OVERRIDE macro, let's remove it. BUG=417463

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	base/compiler_specific.h	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 3 (1 generated)

Mostyn Bramley-Moore

@danakj: here's a pre-prepared CL to remove the OVERRIDE and FINAL macros once we have ...

6 years, 2 months ago (2014-10-07 14:41:08 UTC) #2

danakj

6 years, 2 months ago (2014-10-07 16:01:40 UTC) #3

Oh right, they can just go away eventually. Cool.

I'll come back and review this when it's ready/able to be green on bots.