Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 609793002: Add AX role ,'AXDescriptionList', for dl element(re-land). (Closed)

Created:
6 years, 2 months ago by je_julie(Not used)
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, jamesr, aboxhall, abarth-chromium, dglazkov+blink, dmazzoni, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add AX role ,'AXDescriptionList', for dl element(re-land). There are related patches from WebKit, the patch written by James Craig<james@cookiecrook.com>; wkrev.com/147520 and the patch written by Mario Sanchez Prada <mario.prada@samsung.com>; wkrev.com/161492. And I modified them based on the current blink. BUG=226505 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183062

Patch Set 1 #

Patch Set 2 : Code without LayoutTest #

Patch Set 3 : AX role for description list(rebased) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M Source/core/accessibility/AXList.h View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/accessibility/AXList.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/accessibility/AXNodeObject.cpp View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/accessibility/AXObject.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (5 generated)
je_julie(Not used)
Dominic, PTAL.
6 years, 2 months ago (2014-09-26 12:04:44 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-09-26 16:01:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609793002/1
6 years, 2 months ago (2014-09-26 16:02:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/26624)
6 years, 2 months ago (2014-09-26 17:06:23 UTC) #7
je_julie(Not used)
On 2014/09/26 17:06:23, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-09-27 04:18:38 UTC) #8
dmazzoni
Sounds good. Please upload a new change without the test, and split the test into ...
6 years, 2 months ago (2014-09-29 05:47:11 UTC) #9
je_julie(Not used)
On 2014/09/29 05:47:11, dmazzoni wrote: > Sounds good. Please upload a new change without the ...
6 years, 2 months ago (2014-09-29 06:18:06 UTC) #10
dmazzoni
lgtm
6 years, 2 months ago (2014-09-29 07:01:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609793002/20001
6 years, 2 months ago (2014-09-29 07:02:28 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 182813
6 years, 2 months ago (2014-09-29 09:26:19 UTC) #14
eustas
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/616553002/ by eustas@chromium.org. ...
6 years, 2 months ago (2014-09-29 15:29:33 UTC) #15
je_julie(Not used)
On 2014/09/29 15:29:33, eustas wrote: > A revert of this CL (patchset #2 id:20001) has ...
6 years, 2 months ago (2014-09-30 00:07:41 UTC) #16
shreeramk
On 2014/09/30 00:07:41, je_julie.kim wrote: > On 2014/09/29 15:29:33, eustas wrote: > > A revert ...
6 years, 2 months ago (2014-09-30 11:43:26 UTC) #17
je_julie(Not used)
On 2014/09/30 11:43:26, shreeram.k wrote: > Hi jeongeun, > You could follow below process: > ...
6 years, 2 months ago (2014-09-30 12:43:34 UTC) #18
je_julie(Not used)
This patch is ready to be re-landed. It's rebased on the latest cod without any ...
6 years, 2 months ago (2014-10-01 13:14:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609793002/40001
6 years, 2 months ago (2014-10-01 13:16:18 UTC) #21
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 14:16:38 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183062

Powered by Google App Engine
This is Rietveld 408576698