Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: Source/core/accessibility/AXRenderObject.cpp

Issue 609793002: Add AX role ,'AXDescriptionList', for dl element(re-land). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: AX role for description list(rebased) Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 return HeadingRole; 350 return HeadingRole;
351 351
352 if (m_renderer->isSVGImage()) 352 if (m_renderer->isSVGImage())
353 return ImageRole; 353 return ImageRole;
354 if (m_renderer->isSVGRoot()) 354 if (m_renderer->isSVGRoot())
355 return SVGRootRole; 355 return SVGRootRole;
356 356
357 if (node && node->hasTagName(ddTag)) 357 if (node && node->hasTagName(ddTag))
358 return DescriptionListDetailRole; 358 return DescriptionListDetailRole;
359 359
360 if (node && node->hasTagName(dlTag))
361 return DescriptionListRole;
362
360 if (node && node->hasTagName(dtTag)) 363 if (node && node->hasTagName(dtTag))
361 return DescriptionListTermRole; 364 return DescriptionListTermRole;
362 365
363 if (node && (node->hasTagName(rpTag) || node->hasTagName(rtTag))) 366 if (node && (node->hasTagName(rpTag) || node->hasTagName(rtTag)))
364 return AnnotationRole; 367 return AnnotationRole;
365 368
366 // Table sections should be ignored. 369 // Table sections should be ignored.
367 if (m_renderer->isTableSection()) 370 if (m_renderer->isTableSection())
368 return IgnoredRole; 371 return IgnoredRole;
369 372
(...skipping 2001 matching lines...) Expand 10 before | Expand all | Expand 10 after
2371 if (label && label->renderer()) { 2374 if (label && label->renderer()) {
2372 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect(); 2375 LayoutRect labelRect = axObjectCache()->getOrCreate(label)->elementR ect();
2373 result.unite(labelRect); 2376 result.unite(labelRect);
2374 } 2377 }
2375 } 2378 }
2376 2379
2377 return result; 2380 return result;
2378 } 2381 }
2379 2382
2380 } // namespace blink 2383 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698