Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 607053002: Add conversion rule for WebAXRoleDescriptionList (Closed)

Created:
6 years, 2 months ago by je_julie(Not used)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add conversion rule for WebAXRoleDescriptionList The Related CL: https://codereview.chromium.org/609793002/ BUG=226505 TBR=rockot Committed: https://crrev.com/3cbd462041f96ac311375745876daab4a76bf5b6 Cr-Commit-Position: refs/heads/master@{#297788}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add dl role handling in automation.idl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/common/extensions/api/automation.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/web_ax_object_proxy.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
je_julie(Not used)
Dominic, PTAL.
6 years, 2 months ago (2014-09-26 12:05:32 UTC) #2
je_julie(Not used)
On 2014/09/26 12:05:32, je_julie.kim wrote: > Dominic, PTAL. Hi Dominic, Blink patch, https://codereview.chromium.org/609793002/, related to ...
6 years, 2 months ago (2014-10-01 14:49:02 UTC) #3
dmazzoni
lgtm with one fix https://codereview.chromium.org/607053002/diff/1/ui/accessibility/ax_enums.idl File ui/accessibility/ax_enums.idl (right): https://codereview.chromium.org/607053002/diff/1/ui/accessibility/ax_enums.idl#newcode85 ui/accessibility/ax_enums.idl:85: description_list, See this comment: // ...
6 years, 2 months ago (2014-10-01 19:44:48 UTC) #4
je_julie(Not used)
https://codereview.chromium.org/607053002/diff/1/ui/accessibility/ax_enums.idl File ui/accessibility/ax_enums.idl (right): https://codereview.chromium.org/607053002/diff/1/ui/accessibility/ax_enums.idl#newcode85 ui/accessibility/ax_enums.idl:85: description_list, On 2014/10/01 19:44:48, dmazzoni wrote: > See this ...
6 years, 2 months ago (2014-10-02 01:18:52 UTC) #5
je_julie(Not used)
Dominic, Andy, I added dl for AX role in automation.idl.PTAL.
6 years, 2 months ago (2014-10-02 02:38:14 UTC) #7
dmazzoni
lgtm -Andy +TBR:rockot because the IDL change is trivial
6 years, 2 months ago (2014-10-02 05:22:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607053002/20001
6 years, 2 months ago (2014-10-02 05:23:21 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/19576) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/15752)
6 years, 2 months ago (2014-10-02 05:29:44 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607053002/20001
6 years, 2 months ago (2014-10-02 08:00:04 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3c667aa15021733d8c95162406e424a257e8f61b
6 years, 2 months ago (2014-10-02 09:04:43 UTC) #16
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 09:05:22 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3cbd462041f96ac311375745876daab4a76bf5b6
Cr-Commit-Position: refs/heads/master@{#297788}

Powered by Google App Engine
This is Rietveld 408576698