Source/core/accessibility/AXNodeObject.cpp - Issue 609793002: Add AX role ,'AXDescriptionList', for dl element(re-land).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/accessibility/AXNodeObject.cpp

Issue 609793002: Add AX role ,'AXDescriptionList', for dl element(re-land). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: AX role for description list(rebased) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/accessibility/AXNodeObject.cpp

diff --git a/Source/core/accessibility/AXNodeObject.cpp b/Source/core/accessibility/AXNodeObject.cpp

index ce70d6128ac332de4590dd5abf5863f8d81a24e4..5bf3d8cec5c2eeaa57fd0ba268828c23a8ae526b 100644

--- a/Source/core/accessibility/AXNodeObject.cpp

+++ b/Source/core/accessibility/AXNodeObject.cpp

@@ -33,6 +33,7 @@

#include "core/accessibility/AXObjectCache.h"

#include "core/dom/NodeTraversal.h"

#include "core/dom/Text.h"

+#include "core/html/HTMLDListElement.h"

#include "core/html/HTMLFieldSetElement.h"

#include "core/html/HTMLFrameElementBase.h"

#include "core/html/HTMLInputElement.h"

@@ -245,6 +246,8 @@ AccessibilityRole AXNodeObject::determineAccessibilityRole()

return ParagraphRole;

if (isHTMLLabelElement(*node()))

return LabelRole;

+ if (isHTMLDListElement(*node()))

+ return DescriptionListRole;

if (node()->isElementNode() && node()->hasTagName(figcaptionTag))

return FigcaptionRole;

if (node()->isElementNode() && node()->hasTagName(figureTag))

« no previous file with comments | « Source/core/accessibility/AXList.cpp ('k') | Source/core/accessibility/AXObject.h » ('j') | no next file with comments »