Source/core/html/HTMLFormControlElement.h - Issue 60573007: Non-activated default buttons prevent implicit form submission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormControlElement.h

Issue 60573007: Non-activated default buttons prevent implicit form submission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Retire dated comment on button names Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFormControlElement.h

diff --git a/Source/core/html/HTMLFormControlElement.h b/Source/core/html/HTMLFormControlElement.h

index a241b8be561691ee48f823a0b8b822a27ad5e2e3..c5c24eb6e3b429af2dc828ca6a5cd958bec00744 100644

--- a/Source/core/html/HTMLFormControlElement.h

+++ b/Source/core/html/HTMLFormControlElement.h

@@ -81,7 +81,8 @@ public:

virtual bool appendFormData(FormDataList&, bool) { return false; }

virtual String resultForDialogSubmit();

- virtual bool isSuccessfulSubmitButton() const { return false; }

+ virtual bool canBeSuccessfulSubmitButton() const { return false; }

+ bool isSuccessfulSubmitButton() const;

virtual bool isActivatedSubmit() const { return false; }

virtual void setActivatedSubmit(bool) { }

« no previous file with comments | « Source/core/html/HTMLButtonElement.cpp ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »