Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: Source/core/html/HTMLFormControlElement.h

Issue 60573007: Non-activated default buttons prevent implicit form submission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Retire dated comment on button names Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLButtonElement.cpp ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 74
75 virtual const AtomicString& formControlType() const OVERRIDE = 0; 75 virtual const AtomicString& formControlType() const OVERRIDE = 0;
76 76
77 virtual bool canTriggerImplicitSubmission() const { return false; } 77 virtual bool canTriggerImplicitSubmission() const { return false; }
78 78
79 // Override in derived classes to get the encoded name=value pair for submit ting. 79 // Override in derived classes to get the encoded name=value pair for submit ting.
80 // Return true for a successful control (see HTML4-17.13.2). 80 // Return true for a successful control (see HTML4-17.13.2).
81 virtual bool appendFormData(FormDataList&, bool) { return false; } 81 virtual bool appendFormData(FormDataList&, bool) { return false; }
82 virtual String resultForDialogSubmit(); 82 virtual String resultForDialogSubmit();
83 83
84 virtual bool isSuccessfulSubmitButton() const { return false; } 84 virtual bool canBeSuccessfulSubmitButton() const { return false; }
85 bool isSuccessfulSubmitButton() const;
85 virtual bool isActivatedSubmit() const { return false; } 86 virtual bool isActivatedSubmit() const { return false; }
86 virtual void setActivatedSubmit(bool) { } 87 virtual void setActivatedSubmit(bool) { }
87 88
88 enum CheckValidityDispatchEvents { CheckValidityDispatchEventsAllowed, Check ValidityDispatchEventsNone }; 89 enum CheckValidityDispatchEvents { CheckValidityDispatchEventsAllowed, Check ValidityDispatchEventsNone };
89 90
90 virtual bool willValidate() const; 91 virtual bool willValidate() const;
91 void updateVisibleValidationMessage(); 92 void updateVisibleValidationMessage();
92 void hideVisibleValidationMessage(); 93 void hideVisibleValidationMessage();
93 bool checkValidity(Vector<RefPtr<FormAssociatedElement> >* unhandledInvalidC ontrols = 0, CheckValidityDispatchEvents = CheckValidityDispatchEventsAllowed); 94 bool checkValidity(Vector<RefPtr<FormAssociatedElement> >* unhandledInvalidC ontrols = 0, CheckValidityDispatchEvents = CheckValidityDispatchEventsAllowed);
94 // This must be called when a validation constraint or control value is chan ged. 95 // This must be called when a validation constraint or control value is chan ged.
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 206
206 inline const HTMLFormControlElement& toHTMLFormControlElement(const FormAssociat edElement& control) 207 inline const HTMLFormControlElement& toHTMLFormControlElement(const FormAssociat edElement& control)
207 { 208 {
208 ASSERT_WITH_SECURITY_IMPLICATION(control.isFormControlElement()); 209 ASSERT_WITH_SECURITY_IMPLICATION(control.isFormControlElement());
209 return static_cast<const HTMLFormControlElement&>(control); 210 return static_cast<const HTMLFormControlElement&>(control);
210 } 211 }
211 212
212 } // namespace 213 } // namespace
213 214
214 #endif 215 #endif
OLDNEW
« no previous file with comments | « Source/core/html/HTMLButtonElement.cpp ('k') | Source/core/html/HTMLFormControlElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698