Source/core/html/HTMLFormControlElement.cpp - Issue 60573007: Non-activated default buttons prevent implicit form submission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLFormControlElement.cpp

Issue 60573007: Non-activated default buttons prevent implicit form submission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Retire dated comment on button names Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLFormControlElement.cpp

diff --git a/Source/core/html/HTMLFormControlElement.cpp b/Source/core/html/HTMLFormControlElement.cpp

index e3c52907a668e751fff8cea93f78764b3a88191a..b296b848d6718bfc7ee2c7934fa3b0266a166918 100644

--- a/Source/core/html/HTMLFormControlElement.cpp

+++ b/Source/core/html/HTMLFormControlElement.cpp

@@ -503,6 +503,11 @@ HTMLFormElement* HTMLFormControlElement::virtualForm() const

return FormAssociatedElement::form();

}

+bool HTMLFormControlElement::isSuccessfulSubmitButton() const

+ return canBeSuccessfulSubmitButton() && !isDisabledFormControl();

bool HTMLFormControlElement::isDefaultButtonForForm() const

{

return isSuccessfulSubmitButton() && form() && form()->defaultButton() == this;

« no previous file with comments | « Source/core/html/HTMLFormControlElement.h ('k') | Source/core/html/HTMLFormElement.cpp » ('j') | no next file with comments »