Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: Source/core/html/HTMLButtonElement.cpp

Issue 60573007: Non-activated default buttons prevent implicit form submission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Retire dated comment on button names Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLButtonElement.h ('k') | Source/core/html/HTMLFormControlElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLButtonElement.cpp
diff --git a/Source/core/html/HTMLButtonElement.cpp b/Source/core/html/HTMLButtonElement.cpp
index cebae34c182e2ce6f3a8c329496e02f2130b737a..d70626f755fb1c3aeb840c789a9e76cb2ccdb039 100644
--- a/Source/core/html/HTMLButtonElement.cpp
+++ b/Source/core/html/HTMLButtonElement.cpp
@@ -159,11 +159,9 @@ bool HTMLButtonElement::willRespondToMouseClickEvents()
return HTMLFormControlElement::willRespondToMouseClickEvents();
}
-bool HTMLButtonElement::isSuccessfulSubmitButton() const
+bool HTMLButtonElement::canBeSuccessfulSubmitButton() const
{
- // HTML spec says that buttons must have names to be considered successful.
- // However, other browsers do not impose this constraint.
- return m_type == SUBMIT && !isDisabledFormControl();
+ return m_type == SUBMIT;
}
bool HTMLButtonElement::isActivatedSubmit() const
« no previous file with comments | « Source/core/html/HTMLButtonElement.h ('k') | Source/core/html/HTMLFormControlElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698