|
Fix SkTextBlob offset semantics.
Implement proper x/y drawTextBlob() handling by plumbing a
drawPosText() offset parameter (to act as an additional glyph pos
translation) throughout the device layer.
The new offset superceeds the existing constY, with a minor semantic
tweak: whereas previous implementations were ignoring constY in 2D
positioning mode (scalarsPerGlyph == 2), now the offset is always
observed, in all positioning modes. We can do this because existing
drawPosText() clients always pass constY == 0 for full positioning mode.
R=reed@google.com, jvanverth@google.com, robertphillips@google.com
Committed: https://skia.googlesource.com/skia/+/c13bc571d3e61a43b87eb97f0719abd304cafaf2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+111 lines, -134 lines) |
Patch |
|
M |
experimental/PdfViewer/SkTrackDevice.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
include/core/SkBitmapDevice.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
include/core/SkDevice.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
include/core/SkDraw.h
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
include/device/xps/SkXPSDevice.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
include/pdf/SkPDFDevice.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/core/SkBitmapDevice.cpp
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/core/SkCanvas.cpp
|
View
|
|
2 chunks |
+7 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/core/SkDevice.cpp
|
View
|
1
|
2 chunks |
+6 lines, -24 lines |
0 comments
|
Download
|
|
M |
src/core/SkDraw.cpp
|
View
|
|
5 chunks |
+7 lines, -9 lines |
0 comments
|
Download
|
|
M |
src/core/SkTextMapStateProc.h
|
View
|
|
2 chunks |
+14 lines, -12 lines |
0 comments
|
Download
|
|
M |
src/device/xps/SkXPSDevice.cpp
|
View
|
|
2 chunks |
+3 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/gpu/GrBitmapTextContext.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/gpu/GrBitmapTextContext.cpp
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/gpu/GrDistanceFieldTextContext.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/gpu/GrDistanceFieldTextContext.cpp
|
View
|
|
3 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/gpu/GrStencilAndCoverTextContext.h
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/gpu/GrStencilAndCoverTextContext.cpp
|
View
|
|
7 chunks |
+8 lines, -9 lines |
0 comments
|
Download
|
|
M |
src/gpu/GrTextContext.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/gpu/SkGpuDevice.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/gpu/SkGpuDevice.cpp
|
View
|
|
3 chunks |
+6 lines, -8 lines |
0 comments
|
Download
|
|
M |
src/pdf/SkPDFDevice.cpp
|
View
|
|
2 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/pdf/SkPDFDeviceFlattener.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/pdf/SkPDFDeviceFlattener.cpp
|
View
|
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/utils/SkDeferredCanvas.cpp
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/utils/SkGatherPixelRefsAndRects.h
|
View
|
|
2 chunks |
+7 lines, -12 lines |
0 comments
|
Download
|
|
M |
src/utils/SkPictureUtils.cpp
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
Total messages: 8 (1 generated)
|