Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 609223003: Revert of Fix SkTextBlob offset semantics. (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
CC:
reviews_skia.org, jbroman
Base URL:
https://chromium.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Fix SkTextBlob offset semantics. (patchset #2 id:20001 of https://codereview.chromium.org/605533002/) Reason for revert: Breaking the Chrome builds with the error: [14:54:14.317833] ../../skia/ext/pixel_ref_utils.cc:221:16: error: 'drawPosText' marked 'override' but does not override any member functions [14:54:14.318022] virtual void drawPosText(const SkDraw& draw, [14:54:14.318082] ^ Original issue's description: > Fix SkTextBlob offset semantics. > > Implement proper x/y drawTextBlob() handling by plumbing a > drawPosText() offset parameter (to act as an additional glyph pos > translation) throughout the device layer. > > The new offset superceeds the existing constY, with a minor semantic > tweak: whereas previous implementations were ignoring constY in 2D > positioning mode (scalarsPerGlyph == 2), now the offset is always > observed, in all positioning modes. We can do this because existing > drawPosText() clients always pass constY == 0 for full positioning mode. > > R=reed@google.com, jvanverth@google.com, robertphillips@google.com > > Committed: https://skia.googlesource.com/skia/+/c13bc571d3e61a43b87eb97f0719abd304cafaf2 TBR=jvanverth@google.com,reed@google.com,bsalomon@google.com,fmalita@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d46b8d2bab7cfba8458432248e1568ac377429e9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -111 lines) Patch
M experimental/PdfViewer/SkTrackDevice.h View 1 chunk +3 lines, -3 lines 0 comments Download
M include/core/SkBitmapDevice.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/core/SkDraw.h View 2 chunks +4 lines, -4 lines 0 comments Download
M include/device/xps/SkXPSDevice.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/pdf/SkPDFDevice.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M src/core/SkDevice.cpp View 2 chunks +24 lines, -6 lines 0 comments Download
M src/core/SkDraw.cpp View 5 chunks +9 lines, -7 lines 0 comments Download
M src/core/SkTextMapStateProc.h View 2 chunks +12 lines, -14 lines 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 2 chunks +6 lines, -3 lines 0 comments Download
M src/gpu/GrBitmapTextContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 7 chunks +9 lines, -8 lines 0 comments Download
M src/gpu/GrTextContext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 3 chunks +8 lines, -6 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M src/pdf/SkPDFDeviceFlattener.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/pdf/SkPDFDeviceFlattener.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/SkGatherPixelRefsAndRects.h View 2 chunks +12 lines, -7 lines 0 comments Download
M src/utils/SkPictureUtils.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robertphillips
Created Revert of Fix SkTextBlob offset semantics.
6 years, 2 months ago (2014-09-29 11:48:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609223003/1
6 years, 2 months ago (2014-09-29 11:48:36 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as d46b8d2bab7cfba8458432248e1568ac377429e9
6 years, 2 months ago (2014-09-29 11:48:57 UTC) #3
f(malita)
6 years, 2 months ago (2014-09-29 13:28:38 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/607413003/ by fmalita@chromium.org.

The reason for reverting is: Re-landing: Chromium-side fix to be landed with the
roll (https://codereview.chromium.org/607853003/).

Powered by Google App Engine
This is Rietveld 408576698