Fix SkTextBlob offset semantics.

src/core/SkDevice.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkDevice.h"
 #include "SkDeviceProperties.h"
 #include "SkDraw.h"
@@ skipping 78 matching lines @@
         this->drawVertices(draw, SkCanvas::kTriangles_VertexMode, data.fVertexCount, data.fPoints,
                            data.fTexCoords, data.fColors, xmode, data.fIndices, data.fIndexCount,
                            paint);
     }
 }
 
 void SkBaseDevice::drawTextBlob(const SkDraw& draw, const SkTextBlob* blob, SkScalar x, SkScalar y,
                                 const SkPaint &paint) {
 
     SkPaint runPaint = paint;
-    SkMatrix localMatrix;
-    SkDraw localDraw(draw);
-
-    if (x || y) {
-        localMatrix = *draw.fMatrix;
-        localMatrix.preTranslate(x, y);
-        localDraw.fMatrix = &localMatrix;
-
-        if (paint.getShader()) {
-            // FIXME: We need to compensate for the translate above. This is suboptimal but
-            // temporary -- until we get proper derived class drawTextBlob implementations.
-
-            // TODO: pass x,y down to the other methods so they can handle the additional
-            // translate without needing to allocate a new shader.
-            SkMatrix shaderMatrix;
-            shaderMatrix.setTranslate(-x, -y);
-            SkAutoTUnref<SkShader> wrapper(
-                SkShader::CreateLocalMatrixShader(paint.getShader(), shaderMatrix));
-            runPaint.setShader(wrapper);
-        }
-    }
 
     SkTextBlob::RunIterator it(blob);
     while (!it.done()) {
         size_t textLen = it.glyphCount() * sizeof(uint16_t);
         const SkPoint& offset = it.offset();
         // applyFontToPaint() always overwrites the exact same attributes,
         // so it is safe to not re-seed the paint.
         it.applyFontToPaint(&runPaint);
 
         switch (it.positioning()) {
         case SkTextBlob::kDefault_Positioning:
-            this->drawText(localDraw, it.glyphs(), textLen, offset.x(), offset.y(), runPaint);
+            this->drawText(draw, it.glyphs(), textLen, x + offset.x(), y + offset.y(), runPaint);
             break;
         case SkTextBlob::kHorizontal_Positioning:
+            this->drawPosText(draw, it.glyphs(), textLen, it.pos(), 1,
+                              SkPoint::Make(x, y + offset.y()), runPaint);
+            break;
         case SkTextBlob::kFull_Positioning:
-            this->drawPosText(localDraw, it.glyphs(), textLen, it.pos(), offset.y(),
-                              SkTextBlob::ScalarsPerGlyph(it.positioning()), runPaint);
+            this->drawPosText(draw, it.glyphs(), textLen, it.pos(), 2,
+                              SkPoint::Make(x, y), runPaint);
             break;
         default:
             SkFAIL("unhandled positioning mode");
         }
 
         it.next();
     }
 }
 
 bool SkBaseDevice::readPixels(const SkImageInfo& info, void* dstP, size_t rowBytes, int x, int y) {
@@ skipping 51 matching lines @@
 
 void SkBaseDevice::EXPERIMENTAL_optimize(const SkPicture* picture) {
     // The base class doesn't perform any analysis but derived classes may
 }
 
 bool SkBaseDevice::EXPERIMENTAL_drawPicture(SkCanvas*, const SkPicture*, const SkMatrix*,
                                             const SkPaint*) {
     // The base class doesn't perform any accelerated picture rendering
     return false;
 }