components/password_manager/core/browser/password_form_manager_unittest.cc - Issue 604293002: Improve logging in password manager internals page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 604293002: Improve logging in password manager internals page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/password_manager/chrome_password_manager_client.cc ('K') | « components/autofill/core/common/save_password_progress_logger.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | components/password_manager/core/browser/password_manager_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc

index 99d877aad9341a73a3cd3b47a686f71d5d6f3312..8afbe56241db93ac40d7f83bf5302a4914c09120 100644

--- a/components/password_manager/core/browser/password_form_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc

@@ -67,8 +67,8 @@ class TestPasswordManagerClient : public StubPasswordManagerClient {

return false;

}

- virtual void PromptUserToSavePassword(

- scoped_ptr<PasswordFormManager> form_to_save) OVERRIDE {}

+ virtual bool PromptUserToSavePassword(

vabr (Chromium) 2014/09/26 15:39:47 Actually, PromptUserToSavePassword is already defi

Sunil Ratnu 2014/09/26 16:01:20 Done.

+ scoped_ptr<PasswordFormManager> form_to_save) OVERRIDE { return false;}

virtual PrefService* GetPrefs() OVERRIDE { return &prefs_; }

virtual PasswordStore* GetPasswordStore() OVERRIDE { return password_store_; }

virtual PasswordManagerDriver* GetDriver() OVERRIDE { return &driver_; }