Improve logging in password manager internals page

chrome/browser/password_manager/chrome_password_manager_client.cc

Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 171c355a6e064b58eb5262f19d3e699f2672095f..e481aa6ef5be41ea048a97f08a601f8260a78a1e 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -150,19 +150,20 @@ void ChromePasswordManagerClient::AutofillResultsComputed() {
   sync_credential_was_filtered_ = false;
 }
 
-void ChromePasswordManagerClient::PromptUserToSavePassword(
+bool ChromePasswordManagerClient::PromptUserToSavePassword(
     scoped_ptr<password_manager::PasswordFormManager> form_to_save) {
   // Save password infobar and the password bubble prompts in case of
   // "webby" URLs and do not prompt in case of "non-webby" URLS (e.g. file://).
   if (!BrowsingDataHelper::IsWebScheme(
       web_contents()->GetLastCommittedURL().scheme())) {
-    return;
+    return false;
   }
 
   if (IsTheHotNewBubbleUIEnabled()) {
     ManagePasswordsUIController* manage_passwords_ui_controller =
         ManagePasswordsUIController::FromWebContents(web_contents());
     manage_passwords_ui_controller->OnPasswordSubmitted(form_to_save.Pass());
+    return true;

[vabr (Chromium), 2014/09/26 15:39:47]

Just keep one "return true;" after the whole if-else block.

If you kept this "return true;", then remove the "else" below (see
http://dev.chromium.org/developers/coding-style#Code_Formatting), but I would
prefer the single "return true;" at the end.

[Sunil Ratnu, 2014/09/26 16:01:20]

Done.

   } else {
     std::string uma_histogram_suffix(
         password_manager::metrics_util::GroupIdToString(
@@ -170,6 +171,7 @@ void ChromePasswordManagerClient::PromptUserToSavePassword(
                 form_to_save->realm(), GetPrefs())));
     SavePasswordInfoBarDelegate::Create(
         web_contents(), form_to_save.Pass(), uma_histogram_suffix);
+    return true;
   }
 }