components/password_manager/core/browser/password_manager_client.h - Issue 604293002: Improve logging in password manager internals page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 604293002: Improve logging in password manager internals page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_manager_client.h

diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h

index 474469115eaa056f45dcedae3024ed9113fbf7d9..d1b680cc2f9de20cb488952afe31d95dd72e0569 100644

--- a/components/password_manager/core/browser/password_manager_client.h

+++ b/components/password_manager/core/browser/password_manager_client.h

@@ -52,7 +52,7 @@ class PasswordManagerClient {

// Informs the embedder of a password form that can be saved if the user

// allows it. The embedder is not required to prompt the user if it decides

// that this form doesn't need to be saved.

vabr (Chromium) 2014/09/26 15:39:47 Please comment on the meaning of the return value.

Sunil Ratnu 2014/09/26 16:01:20 Done.

- virtual void PromptUserToSavePassword(

+ virtual bool PromptUserToSavePassword(

scoped_ptr<PasswordFormManager> form_to_save) = 0;

// Called when a password is saved in an automated fashion. Embedder may