Improve logging in password manager internals page

components/password_manager/core/browser/password_form_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/prefs/testing_pref_service.h"
 #include "base/run_loop.h"
@@ skipping 49 matching lines @@
                                            true);
   }
 
   virtual bool ShouldFilterAutofillResult(
       const autofill::PasswordForm& form) OVERRIDE {
     if (form == form_to_filter_)
       return true;
     return false;
   }
 
-  virtual void PromptUserToSavePassword(
-      scoped_ptr<PasswordFormManager> form_to_save) OVERRIDE {}
+  virtual bool PromptUserToSavePassword(

[vabr (Chromium), 2014/09/26 15:39:47]

Actually, PromptUserToSavePassword is already defined in
StubPasswordManagerClient, so please delete the identical re-definition here.
(I'm not sure why it has been repeated here before, but I'm probably responsible
for it. :))

[Sunil Ratnu, 2014/09/26 16:01:20]

Done.

+      scoped_ptr<PasswordFormManager> form_to_save) OVERRIDE { return false;}
   virtual PrefService* GetPrefs() OVERRIDE { return &prefs_; }
   virtual PasswordStore* GetPasswordStore() OVERRIDE { return password_store_; }
   virtual PasswordManagerDriver* GetDriver() OVERRIDE { return &driver_; }
   virtual void AuthenticateAutofillAndFillForm(
       scoped_ptr<autofill::PasswordFormFillData> fill_data) OVERRIDE {
     driver_.FillPasswordForm(*fill_data.get());
   }
 
   void SetFormToFilter(const autofill::PasswordForm& form) {
     form_to_filter_ = form;
@@ skipping 1154 matching lines @@
   EXPECT_CALL(form_manager,
               UploadPasswordForm(_,
                                  autofill::ACCOUNT_CREATION_PASSWORD)).Times(1);
   form_manager.ProvisionallySave(
       form_to_save,
       PasswordFormManager::IGNORE_OTHER_POSSIBLE_USERNAMES);
   form_manager.Save();
 }
 
 }  // namespace password_manager