Animate the accessibility focus ring and fix some minor visual issues.

Animate the accessibility focus ring and fix some minor visual issues.

The look of the focus ring now closely matches the one drawn by the
ChromeVox content script using CSS, and it smoothly animates from one
location to the next.

BUG=314889
Committed: https://crrev.com/cac4d24785305994ddc1dcab6c0d3afbf5ed5c09
Cr-Commit-Position: refs/heads/master@{#296765}

[dmazzoni, 2014-09-24 18:44:13]

dmazzoni@chromium.org changed reviewers:
+ xiyuan@chromium.org

[xiyuan, 2014-09-24 19:40:35]

lgtm

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/ui/accessibility_focus_ring.cc (right):

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring.cc:33: for (int i = 0; i <
36; i++) {
nit: ++i

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring.cc:72: LogRect("Bottom2",
bottom);
Where is LogRect defined?

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring.cc:138: for (size_t i = 1; i
< 36; i++) {
nit: ++i

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/ui/accessibility_focus_ring.h (right):

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring.h:91: gfx::Rect GetBounds()
const;
nit: Missed from previous review. We should move this before |points|.

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc (right):

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc:105: for
(size_t i = 0; i < src_rects.size(); i++) {
nit: ++i

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc (right):

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc:121: int w =
kGradientWidth;
nit: const int w

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc:122: for (int i =
0; i < w; i++) {
nit: ++i

[dmazzoni, 2014-09-24 21:40:57]

Thanks for the fast review!

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/ui/accessibility_focus_ring.cc (right):

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring.cc:33: for (int i = 0; i <
36; i++) {
On 2014/09/24 19:40:35, xiyuan wrote:
> nit: ++i

Done.

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring.cc:72: LogRect("Bottom2",
bottom);
On 2014/09/24 19:40:35, xiyuan wrote:
> Where is LogRect defined?

Sorry, left that in while debugging. Gone.

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring.cc:138: for (size_t i = 1; i
< 36; i++) {
On 2014/09/24 19:40:35, xiyuan wrote:
> nit: ++i

Done.

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/ui/accessibility_focus_ring.h (right):

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring.h:91: gfx::Rect GetBounds()
const;
On 2014/09/24 19:40:35, xiyuan wrote:
> nit: Missed from previous review. We should move this before |points|.

Done.

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc (right):

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc:105: for
(size_t i = 0; i < src_rects.size(); i++) {
On 2014/09/24 19:40:35, xiyuan wrote:
> nit: ++i

Done.

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc (right):

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc:121: int w =
kGradientWidth;
On 2014/09/24 19:40:35, xiyuan wrote:
> nit: const int w

Done.

https://codereview.chromium.org/602813003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc:122: for (int i =
0; i < w; i++) {
On 2014/09/24 19:40:35, xiyuan wrote:
> nit: ++i

Done.

[dmazzoni, 2014-09-24 21:41:33]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-09-24 21:42:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602813003/40001

[commit-bot: I haz the power, 2014-09-24 22:59:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-24 22:59:34]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dmazzoni, 2014-09-25 18:30:30]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-09-25 18:31:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/602813003/60001

[commit-bot: I haz the power, 2014-09-25 19:36:39]

Committed patchset #4 (id:60001) as 4634ebbde3b68f055a0ec816baec5cc65dc56034

[commit-bot: I haz the power, 2014-09-25 19:37:26]

Patchset 4 (id:??) landed as
https://crrev.com/cac4d24785305994ddc1dcab6c0d3afbf5ed5c09
Cr-Commit-Position: refs/heads/master@{#296765}