chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc - Issue 602813003: Animate the accessibility focus ring and fix some minor visual issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc

Issue 602813003: Animate the accessibility focus ring and fix some minor visual issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@focus_ring_in_chromevox

Patch Set: Fix unit tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/ui/accessibility_focus_ring_controller_unittest.cc ('k') | chrome/browser/chromeos/ui/focus_ring_layer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc

diff --git a/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc b/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc

index b5436bd0ab59431804d0fd79ed3d911b1726df1e..56120216e02f755247600b646979752fefacd17f 100644

--- a/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc

+++ b/chrome/browser/chromeos/ui/accessibility_focus_ring_layer.cc

@@ -16,7 +16,7 @@ namespace chromeos {

namespace {

// The number of pixels in the color gradient that fades to transparent.

-const int kGradientWidth = 10;

+const int kGradientWidth = 6;

// The color of the focus ring. In the future this might be a parameter.

const int kFocusRingColorRed = 247;

@@ -118,10 +118,11 @@ void AccessibilityFocusRingLayer::OnPaintLayer(gfx::Canvas* canvas) {

paint.setStrokeWidth(2);

SkPath path;

- for (int i = 0; i < kGradientWidth; i++) {

+ const int w = kGradientWidth;

+ for (int i = 0; i < w; ++i) {

paint.setColor(

SkColorSetARGBMacro(

- 255 - (255 * i / kGradientWidth),

+ 255 * (w - i) * (w - i) / (w * w),

kFocusRingColorRed, kFocusRingColorGreen, kFocusRingColorBlue));

path = MakePath(ring_, i, offset);

canvas->DrawPath(path, paint);