Animate the accessibility focus ring and fix some minor visual issues.

chrome/browser/chromeos/ui/accessibility_focus_ring.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/ui/accessibility_focus_ring.h"
 
+#include "base/logging.h"
+
 namespace chromeos {
 
 // static
 AccessibilityFocusRing AccessibilityFocusRing::CreateWithRect(
     const gfx::Rect& bounds, int margin) {
+  // Compute the height of the top and bottom cap.
+  int cap_height = std::min(bounds.height() / 2, margin * 2);
+
   gfx::Rect top(bounds.x(), bounds.y(),
-                bounds.width(), bounds.height() / 4);
+                bounds.width(), cap_height);
+  gfx::Rect bottom(bounds.x(), bounds.bottom() - cap_height,
+                   bounds.width(), cap_height);
   gfx::Rect body(bounds.x(), top.bottom(),
-                 bounds.width(), bounds.height() / 2);
-  gfx::Rect bottom(bounds.x(), body.bottom(),
-                   bounds.width(), bounds.bottom() - body.bottom());
+                 bounds.width(), bottom.y() - top.bottom());
+
   return CreateWithParagraphShape(top, body, bottom, margin);
 }
 
 // static
+AccessibilityFocusRing AccessibilityFocusRing::Interpolate(
+    const AccessibilityFocusRing& r1,
+    const AccessibilityFocusRing& r2,
+    double fraction) {
+  AccessibilityFocusRing dst;
+  for (int i = 0; i < 36; i++) {

[xiyuan, 2014/09/24 19:40:35]

nit: ++i

[dmazzoni, 2014/09/24 21:40:56]

Done.

+    dst.points[i] = gfx::Point(
+        r1.points[i].x() * (1 - fraction) + r2.points[i].x() * fraction,
+        r1.points[i].y() * (1 - fraction) + r2.points[i].y() * fraction);
+  }
+  return dst;
+}
+
+// static
 AccessibilityFocusRing AccessibilityFocusRing::CreateWithParagraphShape(
     const gfx::Rect& orig_top_line,
     const gfx::Rect& orig_body,
     const gfx::Rect& orig_bottom_line,
     int margin) {
   gfx::Rect top = orig_top_line;
   gfx::Rect middle = orig_body;
   gfx::Rect bottom = orig_bottom_line;
 
+  int min_height = std::min(top.height(), bottom.height());
+  margin = std::min(margin, min_height / 2);
+
   if (top.x() <= middle.x() + 2 * margin) {
     top.set_width(top.width() + top.x() - middle.x());
     top.set_x(middle.x());
   }
   if (top.right() >= middle.right() - 2 * margin) {
     top.set_width(middle.right() - top.x());
   }
 
   if (bottom.x() <= middle.x() + 2 * margin) {
     bottom.set_width(bottom.width() + bottom.x() - middle.x());
     bottom.set_x(middle.x());
   }
   if (bottom.right() >= middle.right() - 2 * margin) {
     bottom.set_width(middle.right() - bottom.x());
   }
 
+  LogRect("Top2", top);
+  LogRect("Body2", middle);
+  LogRect("Bottom2", bottom);

[xiyuan, 2014/09/24 19:40:35]

Where is LogRect defined?

[dmazzoni, 2014/09/24 21:40:56]

Sorry, left that in while debugging. Gone.

+
   AccessibilityFocusRing ring;
   ring.points[0] = gfx::Point(top.x(), top.bottom() - margin);
   ring.points[1] = gfx::Point(top.x(), top.y() + margin);
   ring.points[2] = gfx::Point(top.x(), top.y());
   ring.points[3] = gfx::Point(top.x() + margin, top.y());
   ring.points[4] = gfx::Point(top.right() - margin, top.y());
   ring.points[5] = gfx::Point(top.right(), top.y());
   ring.points[6] = gfx::Point(top.right(), top.y() + margin);
   ring.points[7] = gfx::Point(top.right(), top.bottom() - margin);
   ring.points[8] = gfx::Point(top.right(), top.bottom());
@@ skipping 44 matching lines @@
     ring.points[34] = gfx::Point(top.x(), top.bottom());
   }
   ring.points[35] = gfx::Point(top.x(), top.bottom());
 
   return ring;
 }
 
 gfx::Rect AccessibilityFocusRing::GetBounds() const {
   gfx::Point top_left = points[0];
   gfx::Point bottom_right = points[0];
   for (size_t i = 1; i < 36; i++) {

[xiyuan, 2014/09/24 19:40:35]

nit: ++i

[dmazzoni, 2014/09/24 21:40:56]

Done.

     top_left.SetToMin(points[i]);
     bottom_right.SetToMax(points[i]);
   }
   return gfx::Rect(top_left, gfx::Size(bottom_right.x() - top_left.x(),
                                        bottom_right.y() - top_left.y()));
 }
 
 }  // namespace chromeos