Issue 6026017: Fix/implement new write barrier for x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6026017: Fix/implement new write barrier for x64. (Closed)

Created:
9 years, 11 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/gc/

Visibility:
Public.

Description

Fix/implement new write barrier for x64. Committed: http://code.google.com/p/v8/source/detail?r=6201

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -112 lines)			Patch
M	src/codegen.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	src/heap.h	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	src/heap-inl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/serialize.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/write-buffer.h	View		2 chunks	+2 lines, -11 lines	0 comments	Download
M	src/write-buffer.cc	View		5 chunks	+15 lines, -12 lines	0 comments	Download
A	src/write-buffer-inl.h	View		1 chunk	+56 lines, -0 lines	0 comments	Download
M	src/x64/assembler-x64.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	2 chunks	+58 lines, -6 lines	1 comment	Download
M	src/x64/codegen-x64.cc	View	1	12 chunks	+28 lines, -34 lines	0 comments	Download
M	src/x64/ic-x64.cc	View		5 chunks	+2 lines, -10 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View		6 chunks	+9 lines, -8 lines	0 comments	Download
M	src/x64/macro-assembler-x64.cc	View		8 chunks	+30 lines, -20 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View		2 chunks	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 11 months ago (2011-01-06 12:35:29 UTC) #2

LGTM

http://codereview.chromium.org/6026017/diff/17001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/6026017/diff/17001/src/x64/code-stubs-x64.cc#n...
src/x64/code-stubs-x64.cc:262: __ push(rax);
Does it make sense to make something like

static const Register register_to_save[] = {rcx, rdx, ..., r11};

then write two loops for pushing and poping?

Expand Messages | Collapse Messages