Fix/implement new write barrier for x64.

src/x64/ic-x64.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 251 matching lines @@
 
   // Store the value at the masked, scaled index.
   const int kValueOffset = kElementsStartOffset + kPointerSize;
   __ lea(scratch1, Operand(elements,
                            scratch1,
                            times_pointer_size,
                            kValueOffset - kHeapObjectTag));
   __ movq(Operand(scratch1, 0), value);
 
   // Update write barrier. Make sure not to clobber the value.
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
   __ movq(scratch0, value);
-  __ RecordWrite(elements, scratch1, scratch0);
-#endif
+  __ RecordWrite(elements, scratch1, scratch0, kDontSaveFPRegs);
 }
 
 
 static void GenerateNumberDictionaryLoad(MacroAssembler* masm,
                                          Label* miss,
                                          Register elements,
                                          Register key,
                                          Register r0,
                                          Register r1,
                                          Register r2,
@@ skipping 726 matching lines @@
   // rbx: receiver's elements array (a FixedArray)
   // rcx: index
   NearLabel non_smi_value;
   __ movq(FieldOperand(rbx, rcx, times_pointer_size, FixedArray::kHeaderSize),
           rax);
   __ JumpIfNotSmi(rax, &non_smi_value);
   __ ret(0);
   __ bind(&non_smi_value);
   // Slow case that needs to retain rcx for use by RecordWrite.
   // Update write barrier for the elements array address.
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
   __ movq(rdx, rax);
-  __ RecordWriteNonSmi(rbx, 0, rdx, rcx);
-#endif
+  __ RecordWriteNonSmi(rbx, 0, rdx, rcx, kDontSaveFPRegs);
   __ ret(0);
 }
 
 
 void KeyedStoreIC::GenerateExternalArray(MacroAssembler* masm,
                                          ExternalArrayType array_type) {
   // ----------- S t a t e -------------
   //  -- rax     : value
   //  -- rcx     : key
   //  -- rdx     : receiver
@@ skipping 595 matching lines @@
       address + Assembler::kCallTargetAddressOffset;
 
   // If the instruction following the call is not a test rax, nothing
   // was inlined.
   if (*test_instruction_address != Assembler::kTestEaxByte) return false;
 
   // Extract the encoded deltas from the test rax instruction.
   Address encoded_offsets_address = test_instruction_address + 1;
   int encoded_offsets = *reinterpret_cast<int*>(encoded_offsets_address);
   int delta_to_map_check = -(encoded_offsets & 0xFFFF);
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
   int delta_to_record_write = encoded_offsets >> 16;
-#endif
 
   // Patch the map to check. The map address is the last 8 bytes of
   // the 10-byte immediate move instruction.
   Address map_check_address = test_instruction_address + delta_to_map_check;
   Address map_address = map_check_address + 2;
   *(reinterpret_cast<Object**>(map_address)) = map;
 
   // Patch the offset in the store instruction. The offset is in the
   // last 4 bytes of a 7 byte register-to-memory move instruction.
   Address offset_address =
       map_check_address + StoreIC::kOffsetToStoreInstruction + 3;
   // The offset should have initial value (kMaxInt - 1), cleared value
   // (-1) or we should be clearing the inlined version.
   ASSERT(*reinterpret_cast<int*>(offset_address) == kMaxInt - 1 ||
          *reinterpret_cast<int*>(offset_address) == -1 ||
          (offset == 0 && map == Heap::null_value()));
   *reinterpret_cast<int*>(offset_address) = offset - kHeapObjectTag;
 
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
   // Patch the offset in the write-barrier code. The offset is the
   // last 4 bytes of a 7 byte lea instruction.
   offset_address = map_check_address + delta_to_record_write + 3;
   // The offset should have initial value (kMaxInt), cleared value
   // (-1) or we should be clearing the inlined version.
   ASSERT(*reinterpret_cast<int*>(offset_address) == kMaxInt ||
          *reinterpret_cast<int*>(offset_address) == -1 ||
          (offset == 0 && map == Heap::null_value()));
   *reinterpret_cast<int*>(offset_address) = offset - kHeapObjectTag;
-#endif
 
   return true;
 }
 
 
 static bool PatchInlinedMapCheck(Address address, Object* map) {
   if (V8::UseCrankshaft()) return false;
 
   // Arguments are address of start of call sequence that called
   // the IC,
@@ skipping 291 matching lines @@
 }
 
 void PatchInlinedSmiCode(Address address) {
   UNIMPLEMENTED();
 }
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_X64