Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Unified Diff: src/x64/stub-cache-x64.cc

Issue 6026017: Fix/implement new write barrier for x64. (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/gc/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/x64/code-stubs-x64.cc ('K') | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/x64/stub-cache-x64.cc
===================================================================
--- src/x64/stub-cache-x64.cc (revision 6183)
+++ src/x64/stub-cache-x64.cc (working copy)
@@ -1449,10 +1449,7 @@
__ j(not_equal, &call_builtin);
if (argc == 1) { // Otherwise fall through to call builtin.
- Label exit, attempt_to_grow_elements;
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
- Label with_write_barrier;
-#endif
+ Label exit, attempt_to_grow_elements, with_write_barrier;
// Get the array's length into rax and calculate new length.
__ SmiToInteger32(rax, FieldOperand(rdx, JSArray::kLengthOffset));
@@ -1479,22 +1476,18 @@
// Check if value is a smi.
__ Integer32ToSmi(rax, rax); // Return new length as smi.
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
__ JumpIfNotSmi(rcx, &with_write_barrier);
-#endif
__ bind(&exit);
__ ret((argc + 1) * kPointerSize);
-#ifdef ENABLE_CARDMARKING_WRITE_BARRIER
__ bind(&with_write_barrier);
__ InNewSpace(rbx, rcx, equal, &exit);
- __ RecordWriteHelper(rbx, rdx, rcx);
+ __ RecordWriteHelper(rbx, rdx, rcx, kDontSaveFPRegs);
__ ret((argc + 1) * kPointerSize);
-#endif
__ bind(&attempt_to_grow_elements);
if (!FLAG_inline_new) {
« src/x64/code-stubs-x64.cc ('K') | « src/x64/macro-assembler-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698