Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: src/write-buffer.h

Issue 6026017: Fix/implement new write barrier for x64. (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/gc/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/write-buffer.h
===================================================================
--- src/write-buffer.h (revision 6184)
+++ src/write-buffer.h (working copy)
@@ -41,20 +41,12 @@
// between spaces.
class WriteBuffer : public AllStatic {
public:
- static Address TopAddress() { return reinterpret_cast<Address>(&top_); }
+ static inline Address TopAddress();
static void Setup();
static void TearDown();
- static inline void Mark(Address addr) {
- *top_++ = addr;
- if ((reinterpret_cast<uintptr_t>(top_) & kWriteBufferOverflowBit) != 0) {
- ASSERT(top_ == limit_);
- Compact();
- } else {
- ASSERT(top_ < limit_);
- }
- }
+ static inline void Mark(Address addr);
static const int kWriteBufferOverflowBit = 1 << 16;
static const int kWriteBufferSize = kWriteBufferOverflowBit;
@@ -64,7 +56,6 @@
static void Compact();
private:
- static Address* top_;
static Address* start_;
static Address* limit_;
static VirtualMemory* virtual_memory_;
« no previous file with comments | « src/serialize.cc ('k') | src/write-buffer.cc » ('j') | src/x64/code-stubs-x64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698