Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 599633004: Android WebView: fix missing an invalidate (Closed)

Created:
6 years, 2 months ago by hush (inactive)
Modified:
6 years, 2 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2125
Project:
chromium
Visibility:
Public.

Description

Android WebView: fix missing an invalidate When webview translates into the screen from offscreen by calling WebView#SetTranslateX/Y, onDrawHardware is called with an empty global visible rect. When the webview is still offscreen, Android frameworks won't call DrawGL on WebView, which means the "parent draw constraints" stored in hardware renderer won't contain the draw constraints when the webview is offscreen. When webview gets an ondraw with an empty global visible rect, we need to make sure the parent draw constraints of the corresponding DrawGL is always posted back to child compositor and triggers an invalidate. BUG=417479 Review URL: https://codereview.chromium.org/603633003 Cr-Commit-Position: refs/heads/master@{#296589} (cherry picked from commit 673cf0160d7b5e520841a65f4425f8be1a48fbb1) Conflicts: android_webview/browser/browser_view_renderer.cc android_webview/browser/shared_renderer_state.cc android_webview/browser/shared_renderer_state.h R=boliu@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -18 lines) Patch
M android_webview/browser/browser_view_renderer.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M android_webview/browser/shared_renderer_state.h View 3 chunks +7 lines, -1 line 0 comments Download
M android_webview/browser/shared_renderer_state.cc View 3 chunks +28 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
hush (inactive)
This is the merge CL. It has some conflicts. The conflict resolution is the same ...
6 years, 2 months ago (2014-09-25 18:38:21 UTC) #2
boliu
lgtm
6 years, 2 months ago (2014-09-25 18:39:14 UTC) #3
hush (inactive)
6 years, 2 months ago (2014-09-25 18:45:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as 48a9d68.

Powered by Google App Engine
This is Rietveld 408576698