Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(6)

Issue 603633003: Android WebView: fix missing an invalidate (Closed)

Created:
3 years, 5 months ago by hush (inactive)
Modified:
3 years, 4 months ago
Reviewers:
boliu
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Android WebView: fix missing an invalidate When webview translates into the screen from offscreen by calling WebView#SetTranslateX/Y, onDrawHardware is called with an empty global visible rect. When the webview is still offscreen, Android frameworks won't call DrawGL on WebView, which means the "parent draw constraints" stored in hardware renderer won't contain the draw constraints when the webview is offscreen. When webview gets an ondraw with an empty global visible rect, we need to make sure the parent draw constraints of the corresponding DrawGL is always posted back to child compositor and triggers an invalidate. BUG=417479 Committed: https://crrev.com/673cf0160d7b5e520841a65f4425f8be1a48fbb1 Cr-Commit-Position: refs/heads/master@{#296589}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -18 lines) Patch
M android_webview/browser/browser_view_renderer.cc View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download
M android_webview/browser/hardware_renderer.cc View 1 2 3 1 chunk +4 lines, -5 lines 0 comments Download
M android_webview/browser/shared_renderer_state.h View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M android_webview/browser/shared_renderer_state.cc View 1 2 3 3 chunks +29 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
hush (inactive)
PTAL
3 years, 5 months ago (2014-09-24 19:33:43 UTC) #2
hush (inactive)
just rebased
3 years, 5 months ago (2014-09-24 22:16:02 UTC) #3
boliu
lgtm
3 years, 5 months ago (2014-09-24 22:23:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603633003/60001
3 years, 5 months ago (2014-09-24 23:12:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/2022) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/18768)
3 years, 4 months ago (2014-09-24 23:30:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603633003/60001
3 years, 4 months ago (2014-09-24 23:48:13 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 3df7a42320e01ff50b4ebb7fb6831d8e3b94a84e
3 years, 4 months ago (2014-09-25 00:20:10 UTC) #13
commit-bot: I haz the power
3 years, 4 months ago (2014-09-25 00:20:40 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/673cf0160d7b5e520841a65f4425f8be1a48fbb1
Cr-Commit-Position: refs/heads/master@{#296589}

Powered by Google App Engine
This is Rietveld 408576698