Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 599203003: Implement recursive gyp dependencies for Closure Compilation (Closed)

Created:
6 years, 2 months ago by Vitaly Pavlenko
Modified:
6 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, stevenjb+watch_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@J_jsevalcontext
Project:
chromium
Visibility:
Public.

Description

Implement recursive gyp dependencies for Closure Compilation BUG=78368 R=dbeam@chromium.org TEST=GYP_GENERATORS=ninja gyp --depth . third_party/closure_compiler/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/982046410eb61c3c6d4a0c52b44109a0c4a9d77b Cr-Commit-Position: refs/heads/master@{#297314}

Patch Set 1 #

Patch Set 2 : store depends in list #

Total comments: 8

Patch Set 3 : fixed nits, removed i18n_template config #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -14 lines) Patch
M chrome/browser/resources/downloads/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/history/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/uber/compiled_resources.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/closure_compiler/build/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/closure_compiler/build/inputs.py View 1 2 2 chunks +66 lines, -2 lines 0 comments Download
M third_party/closure_compiler/checker.py View 1 2 3 chunks +8 lines, -2 lines 0 comments Download
M ui/webui/resources/js/chromeos/compiled_resources.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/js/compiled_resources.gyp View 1 2 2 chunks +9 lines, -6 lines 1 comment Download

Messages

Total messages: 10 (1 generated)
Vitaly Pavlenko
6 years, 2 months ago (2014-09-25 18:49:32 UTC) #1
Vitaly Pavlenko
On 2014/09/25 18:49:32, Vitaly Pavlenko wrote: Nah, it doesn't work well. We can't use sets ...
6 years, 2 months ago (2014-09-26 21:02:22 UTC) #2
Vitaly Pavlenko
On 2014/09/26 21:02:22, Vitaly Pavlenko wrote: > On 2014/09/25 18:49:32, Vitaly Pavlenko wrote: > > ...
6 years, 2 months ago (2014-09-26 21:41:40 UTC) #3
Dan Beam
lgtm https://codereview.chromium.org/599203003/diff/20001/third_party/closure_compiler/build/inputs.py File third_party/closure_compiler/build/inputs.py (right): https://codereview.chromium.org/599203003/diff/20001/third_party/closure_compiler/build/inputs.py#newcode17 third_party/closure_compiler/build/inputs.py:17: def remove_duplicates_with_order(list_): nit: list_ => has_dupes https://codereview.chromium.org/599203003/diff/20001/third_party/closure_compiler/build/inputs.py#newcode22 third_party/closure_compiler/build/inputs.py:22: ...
6 years, 2 months ago (2014-09-29 19:23:47 UTC) #4
Vitaly Pavlenko
https://codereview.chromium.org/599203003/diff/20001/third_party/closure_compiler/build/inputs.py File third_party/closure_compiler/build/inputs.py (right): https://codereview.chromium.org/599203003/diff/20001/third_party/closure_compiler/build/inputs.py#newcode17 third_party/closure_compiler/build/inputs.py:17: def remove_duplicates_with_order(list_): On 2014/09/29 19:23:47, Dan Beam wrote: > ...
6 years, 2 months ago (2014-09-29 23:00:34 UTC) #5
Dan Beam
https://codereview.chromium.org/599203003/diff/40001/ui/webui/resources/js/compiled_resources.gyp File ui/webui/resources/js/compiled_resources.gyp (left): https://codereview.chromium.org/599203003/diff/40001/ui/webui/resources/js/compiled_resources.gyp#oldcode46 ui/webui/resources/js/compiled_resources.gyp:46: 'includes': ['../../../../third_party/closure_compiler/compile_js.gypi'], this will conflict with: https://codereview.chromium.org/613023002/
6 years, 2 months ago (2014-09-29 23:02:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/599203003/40001
6 years, 2 months ago (2014-09-29 23:02:18 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as c3d078b5b5fe8c3e540eff8ec1731b928e674e86
6 years, 2 months ago (2014-09-30 00:06:55 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 00:08:16 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/982046410eb61c3c6d4a0c52b44109a0c4a9d77b
Cr-Commit-Position: refs/heads/master@{#297314}

Powered by Google App Engine
This is Rietveld 408576698