Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: ui/webui/resources/js/compiled_resources.gyp

Issue 599203003: Implement recursive gyp dependencies for Closure Compilation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@J_jsevalcontext
Patch Set: fixed nits, removed i18n_template config Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/webui/resources/js/chromeos/compiled_resources.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/webui/resources/js/compiled_resources.gyp
diff --git a/ui/webui/resources/js/compiled_resources.gyp b/ui/webui/resources/js/compiled_resources.gyp
index 5753aa9829c5d83e49d7510970e16f1fe48f9ac5..b8f8aa37e4d8b8410a5d3d9c40ac69c9685192d8 100644
--- a/ui/webui/resources/js/compiled_resources.gyp
+++ b/ui/webui/resources/js/compiled_resources.gyp
@@ -17,6 +17,13 @@
},
{
'target_name': 'load_time_data',
+ 'variables': {
+ 'depends': [
+ '../../../../third_party/jstemplate/util.js',
+ '../../../../third_party/jstemplate/jsevalcontext.js',
+ '../../../../third_party/jstemplate/jstemplate.js',
+ ],
+ },
'includes': ['../../../../third_party/closure_compiler/compile_js.gypi'],
},
{
@@ -37,18 +44,14 @@
{
'target_name': 'i18n_template_no_process',
'variables': {
- 'depends': ['load_time_data.js'],
+ 'depends': ['compiled_resources.gyp:load_time_data'],
},
'includes': ['../../../../third_party/closure_compiler/compile_js.gypi'],
},
{
- 'target_name': 'i18n_template',
- 'includes': ['../../../../third_party/closure_compiler/compile_js.gypi'],
Dan Beam 2014/09/29 23:02:05 this will conflict with: https://codereview.chromi
- },
- {
'target_name': 'i18n_template2',
'variables': {
- 'depends': ['load_time_data.js'],
+ 'depends': ['compiled_resources.gyp:load_time_data'],
},
'includes': ['../../../../third_party/closure_compiler/compile_js.gypi'],
},
« no previous file with comments | « ui/webui/resources/js/chromeos/compiled_resources.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698