Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: third_party/closure_compiler/checker.py

Issue 599203003: Implement recursive gyp dependencies for Closure Compilation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@J_jsevalcontext
Patch Set: fixed nits, removed i18n_template config Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_compiler/checker.py
diff --git a/third_party/closure_compiler/checker.py b/third_party/closure_compiler/checker.py
index 5b215831883f220a85d65d7d1953246e56216c26..b471c767fe374a04a4388ad6f51d57615796bfd5 100755
--- a/third_party/closure_compiler/checker.py
+++ b/third_party/closure_compiler/checker.py
@@ -11,6 +11,8 @@ import re
import subprocess
import sys
import tempfile
+
+import build.inputs
import processor
@@ -168,7 +170,7 @@ class Checker(object):
and its output (as a string).
"""
depends = depends or []
- externs = externs or []
+ externs = externs or set()
if not self._check_java_path():
return 1, ""
@@ -233,7 +235,11 @@ if __name__ == "__main__":
checker = Checker(verbose=opts.verbose)
for source in opts.sources:
- exit, _ = checker.check(source, depends=opts.depends, externs=opts.externs)
+ depends, externs = build.inputs.resolve_recursive_dependencies(
+ source,
+ opts.depends,
+ opts.externs)
+ exit, _ = checker.check(source, depends=depends, externs=externs)
if exit != 0:
sys.exit(exit)

Powered by Google App Engine
This is Rietveld 408576698