Implement recursive gyp dependencies for Closure Compilation

third_party/closure_compiler/checker.py

 #!/usr/bin/python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs Closure compiler on a JavaScript file to check for errors."""
 
 import argparse
 import os
 import re
 import subprocess
 import sys
 import tempfile
 import processor
+import build.inputs

[Dan Beam, 2014/09/29 19:23:47]

nit: separate system modules from user-space, then alphabetize, e.g.

...
import tempfile

import build.inputs
import processor

[Vitaly Pavlenko, 2014/09/29 23:00:33]

Done.

 
 
 class Checker(object):
   """Runs the Closure compiler on a given source file and returns the
   success/errors."""
 
   _COMMON_CLOSURE_ARGS = [
     "--accept_const_keyword",
     "--jscomp_error=accessControls",
     "--jscomp_error=ambiguousFunctionDecl",
@@ skipping 136 matching lines @@
         source_file: A file to check.
         depends: Other files that would be included with a <script> earlier in
             the page.
         externs: @extern files that inform the compiler about custom globals.
 
     Returns:
         (exitcode, output) The exit code of the Closure compiler (as a number)
             and its output (as a string).
     """
     depends = depends or []
     externs = externs or []

[Dan Beam, 2014/09/29 19:23:47]

why not just make this "or set()"?

[Vitaly Pavlenko, 2014/09/29 23:00:33]

Done.

 
     if not self._check_java_path():
       return 1, ""
 
     self._debug("FILE: %s" % source_file)
 
     if source_file.endswith("_externs.js"):
       self._debug("Skipping externs: %s" % source_file)
       return
 
@@ skipping 44 matching lines @@
                       help="Path to a source file to typecheck")
   parser.add_argument("-d", "--depends", nargs=argparse.ZERO_OR_MORE)
   parser.add_argument("-e", "--externs", nargs=argparse.ZERO_OR_MORE)
   parser.add_argument("-o", "--out_file", help="A place to output results")
   parser.add_argument("-v", "--verbose", action="store_true",
                       help="Show more information as this script runs")
   opts = parser.parse_args()
 
   checker = Checker(verbose=opts.verbose)
   for source in opts.sources:
-    exit, _ = checker.check(source, depends=opts.depends, externs=opts.externs)
+    depends, externs = build.inputs.resolve_recursive_dependencies(
+        source,
+        opts.depends,
+        opts.externs)
+    exit, _ = checker.check(source, depends=depends, externs=list(externs))
     if exit != 0:
       sys.exit(exit)
 
     if opts.out_file:
       out_dir = os.path.dirname(opts.out_file)
       if not os.path.exists(out_dir):
         os.makedirs(out_dir)
       # TODO(dbeam): write compiled file to |opts.out_file|.
       open(opts.out_file, "w").write("")