 Chromium Code Reviews
 Chromium Code Reviews Issue 598023004:
  [src/media] Declaring the weak_ptr_factory in proper order in cast,mojo and filters  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 598023004:
  [src/media] Declaring the weak_ptr_factory in proper order in cast,mojo and filters  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: media/mojo/services/mojo_renderer_service.h | 
| diff --git a/media/mojo/services/mojo_renderer_service.h b/media/mojo/services/mojo_renderer_service.h | 
| index 0459c31da633c18f4e08df555146175d8ee91808..42c200c2ac0b5b4783f6c355df2557798b1a1d6c 100644 | 
| --- a/media/mojo/services/mojo_renderer_service.h | 
| +++ b/media/mojo/services/mojo_renderer_service.h | 
| @@ -78,9 +78,9 @@ class MojoRendererService : public mojo::InterfaceImpl<mojo::MediaRenderer> { | 
| // Hence stack-allocating one and passing it to Initialize results in | 
| // undefined badness (e.g, hangs trying to acquire config_lock_); | 
| media::AudioHardwareConfig hardware_config_; | 
| - | 
| - base::WeakPtrFactory<MojoRendererService> weak_factory_; | 
| base::WeakPtr<MojoRendererService> weak_this_; | 
| + base::WeakPtrFactory<MojoRendererService> weak_factory_; | 
| 
xhwang
2014/09/29 16:34:02
ditto
 | 
| + | 
| DISALLOW_COPY_AND_ASSIGN(MojoRendererService); | 
| }; |