Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Unified Diff: media/mojo/services/mojo_renderer_service.h

Issue 598023004: [src/media] Declaring the weak_ptr_factory in proper order in cast,mojo and filters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/services/mojo_renderer_service.h
diff --git a/media/mojo/services/mojo_renderer_service.h b/media/mojo/services/mojo_renderer_service.h
index 0459c31da633c18f4e08df555146175d8ee91808..42c200c2ac0b5b4783f6c355df2557798b1a1d6c 100644
--- a/media/mojo/services/mojo_renderer_service.h
+++ b/media/mojo/services/mojo_renderer_service.h
@@ -78,9 +78,9 @@ class MojoRendererService : public mojo::InterfaceImpl<mojo::MediaRenderer> {
// Hence stack-allocating one and passing it to Initialize results in
// undefined badness (e.g, hangs trying to acquire config_lock_);
media::AudioHardwareConfig hardware_config_;
-
- base::WeakPtrFactory<MojoRendererService> weak_factory_;
base::WeakPtr<MojoRendererService> weak_this_;
+ base::WeakPtrFactory<MojoRendererService> weak_factory_;
xhwang 2014/09/29 16:34:02 ditto
+
DISALLOW_COPY_AND_ASSIGN(MojoRendererService);
};

Powered by Google App Engine
This is Rietveld 408576698