media/mojo/services/mojo_renderer_service.cc - Issue 598023004: [src/media] Declaring the weak_ptr_factory in proper order in cast,mojo and filters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/mojo_renderer_service.cc

Issue 598023004: [src/media] Declaring the weak_ptr_factory in proper order in cast,mojo and filters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/mojo/services/mojo_renderer_service.cc

diff --git a/media/mojo/services/mojo_renderer_service.cc b/media/mojo/services/mojo_renderer_service.cc

index 5109a4253a94c62ef2e9306f720993603ce439d6..9e3664993c8bcc252f3e406a8b93e7f6470f222f 100644

--- a/media/mojo/services/mojo_renderer_service.cc

+++ b/media/mojo/services/mojo_renderer_service.cc

@@ -44,8 +44,8 @@ class MojoRendererApplication

MojoRendererService::MojoRendererService(

mojo::ApplicationConnection* connection)

: hardware_config_(AudioParameters(), AudioParameters()),

- weak_factory_(this),

- weak_this_(weak_factory_.GetWeakPtr()) {

+ weak_factory_(this) {

+ weak_this_ = weak_factory_.GetWeakPtr();

scoped_refptr<base::SingleThreadTaskRunner> runner(

base::MessageLoop::current()->task_runner());

scoped_refptr<MediaLog> media_log(new MediaLog());

« media/mojo/services/mojo_renderer_service.h ('K') | « media/mojo/services/mojo_renderer_service.h ('k') | no next file » | no next file with comments »