[src/media] Declaring the weak_ptr_factory in proper order in cast,mojo and filters

media/filters/renderer_impl.h

Index: media/filters/renderer_impl.h
diff --git a/media/filters/renderer_impl.h b/media/filters/renderer_impl.h
index c41823321308d1875d90989652227b70bcda869d..ae6d4b272c96cc25f052dd4f74d5ba26f7ae9df6 100644
--- a/media/filters/renderer_impl.h
+++ b/media/filters/renderer_impl.h
@@ -151,9 +151,10 @@ class MEDIA_EXPORT RendererImpl : public Renderer {
   bool underflow_disabled_for_testing_;
   bool clockless_video_playback_enabled_for_testing_;
 
+  base::WeakPtr<RendererImpl> weak_this_;
+
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<RendererImpl> weak_factory_;

[xhwang, 2014/09/29 16:34:02]

The order doesn't really matter here. But logically the original order is
correct. |weak_this_| will be invalid if |weak_factory_| is destructed.

-  base::WeakPtr<RendererImpl> weak_this_;
 
   DISALLOW_COPY_AND_ASSIGN(RendererImpl);
 };