Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1276)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/filters/renderer_impl.cc

Issue 598023004: [src/media] Declaring the weak_ptr_factory in proper order in cast,mojo and filters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/filters/renderer_impl.h ('K') | « media/filters/renderer_impl.h ('k') | media/mojo/services/mojo_renderer_service.h » ('j') | media/mojo/services/mojo_renderer_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/renderer_impl.cc
diff --git a/media/filters/renderer_impl.cc b/media/filters/renderer_impl.cc
index e6253e7512aa4786eebd50bb9ac6445e1b04b294..a1fb4080678f309cc7eabfb4c4e26f52839378e2 100644
--- a/media/filters/renderer_impl.cc
+++ b/media/filters/renderer_impl.cc
@@ -36,9 +36,9 @@ RendererImpl::RendererImpl(
video_ended_(false),
underflow_disabled_for_testing_(false),
clockless_video_playback_enabled_for_testing_(false),
- weak_factory_(this),
- weak_this_(weak_factory_.GetWeakPtr()) {
+ weak_factory_(this) {
DVLOG(1) << __FUNCTION__;
+ weak_this_ = weak_factory_.GetWeakPtr();
}
RendererImpl::~RendererImpl() {
« media/filters/renderer_impl.h ('K') | « media/filters/renderer_impl.h ('k') | media/mojo/services/mojo_renderer_service.h » ('j') | media/mojo/services/mojo_renderer_service.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698