Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 597753002: Move paint code from RenderSVGForeignObject to SVGForeignObjectPainter (Closed)

Created:
6 years, 3 months ago by pdr.
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, rune+blink, Stephen Chennney, slimming-paint-reviews_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Move paint code from RenderSVGForeignObject to SVGForeignObjectPainter This patch moves the ForeignObject paint code into the new SVGForeignObjectPainter. This is a straight code move with a few small exceptions: 1) childPoint is now const and is used for all BlockPainter calls. Previously, an extra IntPoint() was used for no reason. 2) FloatRect viewportRect() has been exposed on RenderSVGForeignObject. 3) Fixed up a comment. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182540

Patch Set 1 #

Patch Set 2 : Add SVGForeignObjectPainter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -37 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A Source/core/paint/SVGForeignObjectPainter.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
A Source/core/paint/SVGForeignObjectPainter.cpp View 1 1 chunk +55 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGForeignObject.cpp View 2 chunks +2 lines, -37 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
pdr.
Chris seemed lonely over in core/paint/ so I made him a new SVG friend.
6 years, 3 months ago (2014-09-23 23:24:30 UTC) #2
chrishtr
I think you missed adding the new classes.
6 years, 3 months ago (2014-09-23 23:27:48 UTC) #3
pdr.
On 2014/09/23 23:27:48, chrishtr wrote: > I think you missed adding the new classes. Fixed ...
6 years, 3 months ago (2014-09-23 23:28:38 UTC) #4
chrishtr
lgtm
6 years, 3 months ago (2014-09-23 23:29:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597753002/20001
6 years, 3 months ago (2014-09-23 23:30:18 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/24463)
6 years, 3 months ago (2014-09-24 00:44:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/597753002/20001
6 years, 3 months ago (2014-09-24 00:47:48 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 01:31:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 182540

Powered by Google App Engine
This is Rietveld 408576698