Device info datatype should be moved to components/sync_driver.

Device info datatype should be moved to components/sync_driver.

Moving device_info* and local_device_info_provider.h to components/sync_driver
and updating namespaces for the related classes from browsing_sync to sync_driver.

Most of the changes are mechanical - trivial changes of header files and namespaces.
There are just few less trivial changes:
1) I've removed GetClientName from DeviceInfo because it depended on content/public.
Instead I've inlined GetClientName code (which is rather trivial) in two places where
it was used, including supervised_user_registration_utility.cc.
That required me to update DEPS file for supervised_user. There isn't anything new
in reality - these dependencies already existed indirectly.
2) Added two extra parameters to DeviceInfoDataTypeController to avoid having
direct dependencies on the browser.

TBR=pkasting@chromium.org,yoz@chromium.org
BUG=396136
Committed: https://crrev.com/d0df01813574affc20bb17dfac783ad325d4bb06
Cr-Commit-Position: refs/heads/master@{#296895}

[stanisc, 2014-09-25 06:53:02]

stanisc@chromium.org changed reviewers:
+ bauerb@chromium.org, pkasting@chromium.org, yoz@chromium.org, zea@chromium.org

[stanisc, 2014-09-25 06:53:03]

zea@chromium.org: Please review the change in general - it is mostly the
mechanical renaming with the exception of two slightly less trivial changes I
mentioned in the description.

bauerb@chromium.org: Please review changes in supervised_users (one small change
plus the change to DEPS file). See the description for more details.  

I included yoz@chromium.org and pkasting@chromium.org as TBR reviewers for
extensions and cocoa/webui correspondingly. These changes are all mechanical
renaming.

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm
(right):

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm:24:
#include "components/sync_driver/device_info.h"
The header file was auto-updated by mass-rename.py but it looks like it isn't
needed anymore. Let me know if I should remove it.

[Peter Kasting, 2014-09-25 08:34:22]

LGTM

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm
(right):

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm:24:
#include "components/sync_driver/device_info.h"
On 2014/09/25 06:53:03, stanisc wrote:
> The header file was auto-updated by mass-rename.py but it looks like it isn't
> needed anymore. Let me know if I should remove it.

Yeah, remove anything that's not used.

[Bernhard Bauer, 2014-09-25 08:48:24]

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/supervise...
File chrome/browser/supervised_user/DEPS (right):

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/supervise...
chrome/browser/supervised_user/DEPS:3: "+content/public/browser",
This rule already exists in chrome/browser/DEPS.

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/supervise...
chrome/browser/supervised_user/DEPS:4: "+sync/util/get_session_name.h"
Is there a plan to remove this dependency later? If yes, please add a TODO
referencing a bug. If no, usually include rules refer to whole directories.
Also, I'm not familiar with the reason why sync/util/ isn't publicly visible,
but it seems strange that c/b/supervised_user/ is allowed to depend on it, but
other parts of c/b/ aren't. Other DEPS files that allow sync/util/ are either
part of sync/, or temporary exceptions (see above).

[stanisc, 2014-09-25 18:58:34]

stanisc@chromium.org changed reviewers:
+ sky@chromium.org

[stanisc, 2014-09-25 18:58:35]

Addressed CR feedback.

sky@chromium.org: Please review changes in chrome/browser/DEPS.

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/supervise...
File chrome/browser/supervised_user/DEPS (right):

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/supervise...
chrome/browser/supervised_user/DEPS:3: "+content/public/browser",
On 2014/09/25 08:48:24, Bernhard Bauer wrote:
> This rule already exists in chrome/browser/DEPS.

Done.

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/supervise...
chrome/browser/supervised_user/DEPS:4: "+sync/util/get_session_name.h"
On 2014/09/25 08:48:24, Bernhard Bauer wrote:
> Is there a plan to remove this dependency later? If yes, please add a TODO
> referencing a bug. If no, usually include rules refer to whole directories.
> Also, I'm not familiar with the reason why sync/util/ isn't publicly visible,
> but it seems strange that c/b/supervised_user/ is allowed to depend on it, but
> other parts of c/b/ aren't. Other DEPS files that allow sync/util/ are either
> part of sync/, or temporary exceptions (see above).
OK. I've reverted changes in this file and moved sync/util to the parent level
DEPS.

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm
(right):

https://codereview.chromium.org/597423002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm:24:
#include "components/sync_driver/device_info.h"
On 2014/09/25 08:34:22, Peter Kasting wrote:
> On 2014/09/25 06:53:03, stanisc wrote:
> > The header file was auto-updated by mass-rename.py but it looks like it
isn't
> > needed anymore. Let me know if I should remove it.
> 
> Yeah, remove anything that's not used.

Done.

[Nicolas Zea, 2014-09-25 20:32:56]

LGTM

https://codereview.chromium.org/597423002/diff/40001/components/sync_driver/d...
File components/sync_driver/device_info_data_type_controller.h (right):

https://codereview.chromium.org/597423002/diff/40001/components/sync_driver/d...
components/sync_driver/device_info_data_type_controller.h:18:
scoped_refptr<base::MessageLoopProxy> ui_thread,
nit: pass scoped_refptrs as const ref (i.e. const scoped_refptr<...>& ui_thread)

[sky, 2014-09-25 23:34:14]

DEPS LGTM

[Bernhard Bauer, 2014-09-25 23:37:07]

LGTM!

[stanisc, 2014-09-26 05:58:35]

The CQ bit was checked by stanisc@chromium.org

[commit-bot: I haz the power, 2014-09-26 05:59:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/597423002/60001

[commit-bot: I haz the power, 2014-09-26 06:17:44]

Committed patchset #4 (id:60001) as 178181a18d5adcc40e8dd256072e48726c6ac81c

[commit-bot: I haz the power, 2014-09-26 06:18:18]

Patchset 4 (id:??) landed as
https://crrev.com/d0df01813574affc20bb17dfac783ad325d4bb06
Cr-Commit-Position: refs/heads/master@{#296895}