Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: components/sync_driver/device_info.h

Issue 597423002: Device info datatype should be moved to components/sync_driver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor CR feedback addressed. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync_driver/BUILD.gn ('k') | components/sync_driver/device_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync_driver/device_info.h
diff --git a/chrome/browser/sync/glue/device_info.h b/components/sync_driver/device_info.h
similarity index 88%
rename from chrome/browser/sync/glue/device_info.h
rename to components/sync_driver/device_info.h
index 3faf6689442f694ff0abd1fdcc8a2c7d90b2ef66..d2a8f49a67b4e4669661d90c31063dceb1f218ab 100644
--- a/chrome/browser/sync/glue/device_info.h
+++ b/components/sync_driver/device_info.h
@@ -2,8 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_BROWSER_SYNC_GLUE_DEVICE_INFO_H_
-#define CHROME_BROWSER_SYNC_GLUE_DEVICE_INFO_H_
+#ifndef COMPONENTS_SYNC_DRIVER_DEVICE_INFO_H_
+#define COMPONENTS_SYNC_DRIVER_DEVICE_INFO_H_
#include <string>
@@ -15,13 +15,11 @@ namespace base {
class DictionaryValue;
}
-namespace browser_sync {
+namespace sync_driver {
// A class that holds information regarding the properties of a device.
class DeviceInfo {
public:
- typedef base::Callback<void(const std::string&)> GetClientNameCallback;
-
DeviceInfo(const std::string& guid,
const std::string& client_name,
const std::string& chrome_version,
@@ -76,9 +74,6 @@ class DeviceInfo {
// which extension APIs can expose to third party apps.
base::DictionaryValue* ToValue();
- // Gets the local device name and passes it as a parameter to callback.
- static void GetClientName(const GetClientNameCallback& callback);
-
private:
const std::string guid_;
@@ -101,6 +96,6 @@ class DeviceInfo {
DISALLOW_COPY_AND_ASSIGN(DeviceInfo);
};
-} // namespace browser_sync
+} // namespace sync_driver
-#endif // CHROME_BROWSER_SYNC_GLUE_DEVICE_INFO_H_
+#endif // COMPONENTS_SYNC_DRIVER_DEVICE_INFO_H_
« no previous file with comments | « components/sync_driver/BUILD.gn ('k') | components/sync_driver/device_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698