chrome/browser/supervised_user/DEPS - Issue 597423002: Device info datatype should be moved to components/sync_driver.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/supervised_user/DEPS

Issue 597423002: Device info datatype should be moved to components/sync_driver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated BUILD.gn for sync_driver Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/api/signed_in_devices/signed_in_devices_manager.cc ('k') | chrome/browser/supervised_user/supervised_user_registration_utility.cc » ('j') | chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller_unittest.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/user_manager",	2 "+components/user_manager",

	3 "+content/public/browser",
	Bernhard Bauer 2014/09/25 08:48:24 This rule already exists in chrome/browser/DEPS. This rule already exists in chrome/browser/DEPS. stanisc 2014/09/25 18:58:35 Done. Show quoted text On 2014/09/25 08:48:24, Bernhard Bauer wrote: > This rule already exists in chrome/browser/DEPS. Done.
	4 "+sync/util/get_session_name.h"
	Bernhard Bauer 2014/09/25 08:48:24 Is there a plan to remove this dependency later? I Is there a plan to remove this dependency later? If yes, please add a TODO referencing a bug. If no, usually include rules refer to whole directories. Also, I'm not familiar with the reason why sync/util/ isn't publicly visible, but it seems strange that c/b/supervised_user/ is allowed to depend on it, but other parts of c/b/ aren't. Other DEPS files that allow sync/util/ are either part of sync/, or temporary exceptions (see above). stanisc 2014/09/25 18:58:35 OK. I've reverted changes in this file and moved s Show quoted text On 2014/09/25 08:48:24, Bernhard Bauer wrote: > Is there a plan to remove this dependency later? If yes, please add a TODO > referencing a bug. If no, usually include rules refer to whole directories. > Also, I'm not familiar with the reason why sync/util/ isn't publicly visible, > but it seems strange that c/b/supervised_user/ is allowed to depend on it, but > other parts of c/b/ aren't. Other DEPS files that allow sync/util/ are either > part of sync/, or temporary exceptions (see above). OK. I've reverted changes in this file and moved sync/util to the parent level DEPS.
3 ]	5 ]

OLD	NEW