Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/sync/glue/device_info_sync_service.h

Issue 597423002: Device info datatype should be moved to components/sync_driver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Minor CR feedback addressed. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/device_info_sync_service.h
diff --git a/chrome/browser/sync/glue/device_info_sync_service.h b/chrome/browser/sync/glue/device_info_sync_service.h
deleted file mode 100644
index d638e538977481174570cf7732573c233338be7d..0000000000000000000000000000000000000000
--- a/chrome/browser/sync/glue/device_info_sync_service.h
+++ /dev/null
@@ -1,108 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_SYNC_GLUE_DEVICE_INFO_SYNC_SERVICE_H_
-#define CHROME_BROWSER_SYNC_GLUE_DEVICE_INFO_SYNC_SERVICE_H_
-
-#include "base/observer_list.h"
-#include "chrome/browser/sync/glue/device_info_tracker.h"
-#include "sync/api/sync_change_processor.h"
-#include "sync/api/sync_data.h"
-#include "sync/api/sync_error_factory.h"
-#include "sync/api/syncable_service.h"
-
-namespace browser_sync {
-
-class LocalDeviceInfoProvider;
-
-// SyncableService implementation for DEVICE_INFO model type.
-class DeviceInfoSyncService : public syncer::SyncableService,
- public DeviceInfoTracker {
- public:
- explicit DeviceInfoSyncService(
- LocalDeviceInfoProvider* local_device_info_provider);
- virtual ~DeviceInfoSyncService();
-
- // syncer::SyncableService implementation.
- virtual syncer::SyncMergeResult MergeDataAndStartSyncing(
- syncer::ModelType type,
- const syncer::SyncDataList& initial_sync_data,
- scoped_ptr<syncer::SyncChangeProcessor> sync_processor,
- scoped_ptr<syncer::SyncErrorFactory> error_handler) OVERRIDE;
- virtual void StopSyncing(syncer::ModelType type) OVERRIDE;
- virtual syncer::SyncDataList GetAllSyncData(
- syncer::ModelType type) const OVERRIDE;
- virtual syncer::SyncError ProcessSyncChanges(
- const tracked_objects::Location& from_here,
- const syncer::SyncChangeList& change_list) OVERRIDE;
-
- // DeviceInfoTracker implementation.
- virtual scoped_ptr<DeviceInfo> GetDeviceInfo(
- const std::string& client_id) const OVERRIDE;
- virtual ScopedVector<DeviceInfo> GetAllDeviceInfo() const OVERRIDE;
- virtual void AddObserver(Observer* observer) OVERRIDE;
- virtual void RemoveObserver(Observer* observer) OVERRIDE;
-
- // Called to update local device backup time.
- void UpdateLocalDeviceBackupTime(base::Time backup_time);
- // Gets the most recently set local device backup time.
- base::Time GetLocalDeviceBackupTime() const;
-
- private:
- // Create SyncData from local DeviceInfo and |local_device_backup_time_|.
- syncer::SyncData CreateLocalData(const DeviceInfo* info);
- // Create SyncData from EntitySpecifics.
- static syncer::SyncData CreateLocalData(
- const sync_pb::EntitySpecifics& entity);
-
- // Allocate new DeviceInfo from SyncData.
- static DeviceInfo* CreateDeviceInfo(const syncer::SyncData sync_data);
- // Store SyncData in the cache.
- void StoreSyncData(const std::string& client_id,
- const syncer::SyncData& sync_data);
- // Delete SyncData from the cache.
- void DeleteSyncData(const std::string& client_id);
- // Notify all registered observers.
- void NotifyObservers();
-
- // Updates backup time in place in |sync_data| if it is different than
- // the one stored in |local_device_backup_time_|.
- // Returns true if backup time was updated.
- bool UpdateBackupTime(syncer::SyncData* sync_data);
-
- // |local_device_backup_time_| accessors.
- int64 local_device_backup_time() const { return local_device_backup_time_; }
- bool has_local_device_backup_time() const {
- return local_device_backup_time_ >= 0;
- }
- void set_local_device_backup_time(int64 value) {
- local_device_backup_time_ = value;
- }
- void clear_local_device_backup_time() { local_device_backup_time_ = -1; }
-
- // Local device last set backup time (in proto format).
- // -1 if the value hasn't been specified
- int64 local_device_backup_time_;
-
- // |local_device_info_provider_| isn't owned.
- const LocalDeviceInfoProvider* const local_device_info_provider_;
-
- // Receives ownership of |sync_processor_| and |error_handler_| in
- // MergeDataAndStartSyncing() and destroy them in StopSyncing().
- scoped_ptr<syncer::SyncChangeProcessor> sync_processor_;
- scoped_ptr<syncer::SyncErrorFactory> error_handler_;
-
- // Cache of all syncable and local data.
- typedef std::map<std::string, syncer::SyncData> SyncDataMap;
- SyncDataMap all_data_;
-
- // Registered observers, not owned.
- ObserverList<Observer, true> observers_;
-
- DISALLOW_COPY_AND_ASSIGN(DeviceInfoSyncService);
-};
-
-} // namespace browser_sync
-
-#endif // CHROME_BROWSER_SYNC_GLUE_DEVICE_INFO_SYNC_SERVICE_H_

Powered by Google App Engine
This is Rietveld 408576698