Make the setItem CONTENT_SETTING_ASK dialog more useful by showing the actual...

Make the setItem CONTENT_SETTING_ASK dialog more useful by showing the actual key and value.  Unfortunately, we're going to have to abuse cookie strings for 4.1  Once this goes in, I'll add new strings for the actual fields.

This also cleans up the code some.

TEST=Instead of size/modified information you'll see "name" and "content" in the dialog that comes up when asking whether to allow local storage.
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38952

[darin (slow to review), 2010-02-12 20:55:52]

LGTM

http://codereview.chromium.org/597061/diff/1/13
File chrome/browser/cookie_modal_dialog.h (right):

http://codereview.chromium.org/597061/diff/1/13#newcode22
chrome/browser/cookie_modal_dialog.h:22: DIALOG_TYPE_COOKIE=0,
_COOKIE = 0  <-- whitespace

http://codereview.chromium.org/597061/diff/1/11
File chrome/browser/in_process_webkit/dom_storage_permission_request.cc (right):

http://codereview.chromium.org/597061/diff/1/11#newcode63
chrome/browser/in_process_webkit/dom_storage_permission_request.cc:63:
dom_storage_permission_request->url().host(),
in http://codereview.chromium.org/597031, i actually change the cookie prompt
code to store a GURL instead of a hostname for cookies.  (this is needed in
order to compute the effective path of a cookie properly.)  anyways, we could
also just plumb dom_storage_permission_request->url() here.  or, perhaps it is
easier for me to do that once you have committed this cl.

[jorlow, 2010-02-12 21:22:42]

http://codereview.chromium.org/597061/diff/1/13
File chrome/browser/cookie_modal_dialog.h (right):

http://codereview.chromium.org/597061/diff/1/13#newcode22
chrome/browser/cookie_modal_dialog.h:22: DIALOG_TYPE_COOKIE=0,
On 2010/02/12 20:55:52, darin wrote:
> _COOKIE = 0  <-- whitespace

Doing...

http://codereview.chromium.org/597061/diff/1/11
File chrome/browser/in_process_webkit/dom_storage_permission_request.cc (right):

http://codereview.chromium.org/597061/diff/1/11#newcode63
chrome/browser/in_process_webkit/dom_storage_permission_request.cc:63:
dom_storage_permission_request->url().host(),
On 2010/02/12 20:55:52, darin wrote:
> in http://codereview.chromium.org/597031, i actually change the cookie prompt
> code to store a GURL instead of a hostname for cookies.  (this is needed in
> order to compute the effective path of a cookie properly.)  anyways, we could
> also just plumb dom_storage_permission_request->url() here.  or, perhaps it is
> easier for me to do that once you have committed this cl.

I'll switch it over to a GURL.