Make the setItem CONTENT_SETTING_ASK dialog more useful by showing the actual...

chrome/browser/in_process_webkit/dom_storage_permission_request.cc

Index: chrome/browser/in_process_webkit/dom_storage_permission_request.cc
===================================================================
--- chrome/browser/in_process_webkit/dom_storage_permission_request.cc	(revision 38896)
+++ chrome/browser/in_process_webkit/dom_storage_permission_request.cc	(working copy)
@@ -9,14 +9,12 @@
 
 DOMStoragePermissionRequest::DOMStoragePermissionRequest(
     const GURL& url,
-    bool file_exists,
-    int64 size,
-    base::Time last_modified,
+    const string16& key,
+    const string16& value,
     HostContentSettingsMap* settings)
     : url_(url),
-      file_exists_(file_exists),
-      size_(size),
-      last_modified_(last_modified),
+      key_(key),
+      value_(value),
       event_(true, false),  // manual reset, not initially signaled
       host_content_settings_map_(settings) {
 }
@@ -62,15 +60,9 @@
   // showed the name and value being stored (as is done for cookies).
   const std::string& host = dom_storage_permission_request->url().host();
   RunLocalStoragePrompt(browser->GetSelectedTabContents(),
-                        BrowsingDataLocalStorageHelper::LocalStorageInfo(
-                            std::string(),
-                            host,
-                            -1,
-                            std::string(),
-                            host,
-                            FilePath(),
-                            dom_storage_permission_request->size(),
-                            dom_storage_permission_request->last_modified()),
+                        dom_storage_permission_request->url().host(),

[darin (slow to review), 2010/02/12 20:55:52]

in http://codereview.chromium.org/597031, i actually change the cookie prompt
code to store a GURL instead of a hostname for cookies.  (this is needed in
order to compute the effective path of a cookie properly.)  anyways, we could
also just plumb dom_storage_permission_request->url() here.  or, perhaps it is
easier for me to do that once you have committed this cl.

[jorlow, 2010/02/12 21:22:42]

I'll switch it over to a GURL.

+                        dom_storage_permission_request->key(),
+                        dom_storage_permission_request->value(),
                         dom_storage_permission_request);
 #else
   // TODO(darin): Enable prompting for other ports.