Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3855)

Unified Diff: chrome/browser/in_process_webkit/dom_storage_permission_request.h

Issue 597061: Make the setItem CONTENT_SETTING_ASK dialog more useful by showing the actual... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/in_process_webkit/dom_storage_permission_request.h
===================================================================
--- chrome/browser/in_process_webkit/dom_storage_permission_request.h (revision 38896)
+++ chrome/browser/in_process_webkit/dom_storage_permission_request.h (working copy)
@@ -20,9 +20,8 @@
class DOMStoragePermissionRequest : public CookiePromptModalDialogDelegate {
public:
DOMStoragePermissionRequest(const GURL& url,
- bool file_exists,
- int64 size,
- base::Time last_modified,
+ const string16& key,
+ const string16& value,
HostContentSettingsMap* settings);
@@ -30,9 +29,8 @@
void SendResponse(ContentSetting content_setting, bool remember);
const GURL& url() const { return url_; }
- bool file_exists() const { return file_exists_; }
- int64 size() const { return size_; }
- const base::Time last_modified() const { return last_modified_; }
+ const string16& key() const { return key_; }
+ const string16& value() const { return value_; }
// Called on the UI thread.
static void PromptUser(DOMStoragePermissionRequest* request);
@@ -45,15 +43,12 @@
// The URL we need to get permission for.
const GURL url_;
- // Is there any information on disk currently?
- bool file_exists_;
+ // The key we're trying to set.
+ const string16 key_;
- // If file_exists_, what's the size?
- int64 size_;
+ // The value we're trying to set.
+ const string16 value_;
- // If file_exists_, what's the size?
- const base::Time last_modified_;
-
// The response to the permission request.
ContentSetting response_content_setting_;

Powered by Google App Engine
This is Rietveld 408576698