Make the setItem CONTENT_SETTING_ASK dialog more useful by showing the actual...

chrome/browser/in_process_webkit/dom_storage_permission_request.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/in_process_webkit/dom_storage_permission_request.h"
 
 #include "chrome/browser/browser_list.h"
 #include "chrome/browser/message_box_handler.h"
 
 DOMStoragePermissionRequest::DOMStoragePermissionRequest(
     const GURL& url,
-    bool file_exists,
-    int64 size,
-    base::Time last_modified,
+    const string16& key,
+    const string16& value,
     HostContentSettingsMap* settings)
     : url_(url),
-      file_exists_(file_exists),
-      size_(size),
-      last_modified_(last_modified),
+      key_(key),
+      value_(value),
       event_(true, false),  // manual reset, not initially signaled
       host_content_settings_map_(settings) {
 }
 
 ContentSetting DOMStoragePermissionRequest::WaitOnResponse() {
   event_.Wait();
   return response_content_setting_;
 }
 
 void DOMStoragePermissionRequest::SendResponse(ContentSetting content_setting,
@@ skipping 25 matching lines @@
   if (!browser || !browser->GetSelectedTabContents()) {
     dom_storage_permission_request->SendResponse(CONTENT_SETTING_BLOCK, false);
     return;
   }
 
 #if defined(OS_WIN)
   // TODO(darin): It seems like it would be interesting if the dialog actually
   // showed the name and value being stored (as is done for cookies).
   const std::string& host = dom_storage_permission_request->url().host();
   RunLocalStoragePrompt(browser->GetSelectedTabContents(),
-                        BrowsingDataLocalStorageHelper::LocalStorageInfo(
-                            std::string(),
-                            host,
-                            -1,
-                            std::string(),
-                            host,
-                            FilePath(),
-                            dom_storage_permission_request->size(),
-                            dom_storage_permission_request->last_modified()),
+                        dom_storage_permission_request->url().host(),

[darin (slow to review), 2010/02/12 20:55:52]

in http://codereview.chromium.org/597031, i actually change the cookie prompt
code to store a GURL instead of a hostname for cookies.  (this is needed in
order to compute the effective path of a cookie properly.)  anyways, we could
also just plumb dom_storage_permission_request->url() here.  or, perhaps it is
easier for me to do that once you have committed this cl.

[jorlow, 2010/02/12 21:22:42]

I'll switch it over to a GURL.

+                        dom_storage_permission_request->key(),
+                        dom_storage_permission_request->value(),
                         dom_storage_permission_request);
 #else
   // TODO(darin): Enable prompting for other ports.
   dom_storage_permission_request->SendResponse(CONTENT_SETTING_BLOCK, false);
 #endif
 }
 
 void DOMStoragePermissionRequest::AllowSiteData(bool remember,
                                                 bool session_expire) {
   // The session_expire parameter is not relevant.
   SendResponse(CONTENT_SETTING_ALLOW, remember);
 }
 
 void DOMStoragePermissionRequest::BlockSiteData(bool remember) {
   SendResponse(CONTENT_SETTING_BLOCK, remember);
 }