Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 596653006: Have MixedContentChecker and ProgressTracker keep a LocalFrame Member. (Closed)

Created:
6 years, 3 months ago by sof
Modified:
6 years, 2 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Have MixedContentChecker and ProgressTracker keep a LocalFrame Member. Tidy up the Oilpan handling of these two FrameLoader-owned objects, and arrange it so that their LocalFrame back references are correctly traced. R=haraken,mkwst BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -22 lines) Patch
M Source/core/loader/FrameLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/loader/MixedContentChecker.h View 4 chunks +6 lines, -2 lines 0 comments Download
M Source/core/loader/MixedContentChecker.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/loader/ProgressTracker.h View 3 chunks +9 lines, -15 lines 0 comments Download
M Source/core/loader/ProgressTracker.cpp View 2 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
sof
Please take a look. mkwst: if https://codereview.chromium.org/566533003 will be re-landed soon, then leaving MixedContentChecker alone ...
6 years, 3 months ago (2014-09-24 13:50:21 UTC) #2
haraken
LGTM
6 years, 3 months ago (2014-09-24 14:00:17 UTC) #3
Mike West
On 2014/09/24 13:50:21, sof wrote: > Please take a look. LGTM. > mkwst: if https://codereview.chromium.org/566533003 ...
6 years, 3 months ago (2014-09-24 14:00:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596653006/1
6 years, 3 months ago (2014-09-24 15:20:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/28602)
6 years, 3 months ago (2014-09-24 16:43:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596653006/1
6 years, 3 months ago (2014-09-24 17:48:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/28632)
6 years, 3 months ago (2014-09-24 20:00:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/596653006/1
6 years, 3 months ago (2014-09-25 05:30:52 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 06:42:02 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182652

Powered by Google App Engine
This is Rietveld 408576698