Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1048)

Side by Side Diff: Source/core/loader/ProgressTracker.h

Issue 596653006: Have MixedContentChecker and ProgressTracker keep a LocalFrame Member. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/loader/MixedContentChecker.cpp ('k') | Source/core/loader/ProgressTracker.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE COMPUTER, INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #ifndef ProgressTracker_h 26 #ifndef ProgressTracker_h
27 #define ProgressTracker_h 27 #define ProgressTracker_h
28 28
29 #include "platform/heap/Handle.h"
29 #include "wtf/FastAllocBase.h" 30 #include "wtf/FastAllocBase.h"
30 #include "wtf/Forward.h" 31 #include "wtf/Forward.h"
31 #include "wtf/HashMap.h" 32 #include "wtf/HashMap.h"
32 #include "wtf/Noncopyable.h" 33 #include "wtf/Noncopyable.h"
33 #include "wtf/OwnPtr.h" 34 #include "wtf/OwnPtr.h"
34 #include "wtf/RefPtr.h"
35 35
36 namespace blink { 36 namespace blink {
37 37
38 class LocalFrame; 38 class LocalFrame;
39 class ResourceResponse; 39 class ResourceResponse;
40 struct ProgressItem; 40 struct ProgressItem;
41 41
42 // FIXME: This is only used on Android. Android is the only Chrome 42 // FIXME: This is only used on Android. Android is the only Chrome
43 // browser which shows a progress bar during loading. 43 // browser which shows a progress bar during loading.
44 // We should find a better way for Android to get this data and remove this! 44 // We should find a better way for Android to get this data and remove this!
45 class ProgressTracker { 45 class ProgressTracker FINAL : public NoBaseWillBeGarbageCollectedFinalized<Progr essTracker> {
46 WTF_MAKE_NONCOPYABLE(ProgressTracker); WTF_MAKE_FAST_ALLOCATED; 46 WTF_MAKE_NONCOPYABLE(ProgressTracker); WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOV ED;
47 public: 47 public:
48 static PassOwnPtrWillBeRawPtr<ProgressTracker> create(LocalFrame*);
49
48 ~ProgressTracker(); 50 ~ProgressTracker();
49 51 void trace(Visitor*);
50 static PassOwnPtr<ProgressTracker> create(LocalFrame*); 52 void dispose();
51 53
52 double estimatedProgress() const; 54 double estimatedProgress() const;
53 55
54 void progressStarted(); 56 void progressStarted();
55 void progressCompleted(); 57 void progressCompleted();
56 58
57 void incrementProgress(unsigned long identifier, const ResourceResponse&); 59 void incrementProgress(unsigned long identifier, const ResourceResponse&);
58 void incrementProgress(unsigned long identifier, const char*, int); 60 void incrementProgress(unsigned long identifier, const char*, int);
59 void completeProgress(unsigned long identifier); 61 void completeProgress(unsigned long identifier);
60 62
61 long long totalPageAndResourceBytesToLoad() const { return m_totalPageAndRes ourceBytesToLoad; } 63 long long totalPageAndResourceBytesToLoad() const { return m_totalPageAndRes ourceBytesToLoad; }
62 long long totalBytesReceived() const { return m_totalBytesReceived; } 64 long long totalBytesReceived() const { return m_totalBytesReceived; }
63 65
64 private: 66 private:
65 ProgressTracker(LocalFrame*); 67 explicit ProgressTracker(LocalFrame*);
66 68
67 void reset(); 69 void reset();
68 70
69 // This bare frame pointer is safe; it refers to the 71 RawPtrWillBeMember<LocalFrame> m_frame;
70 // owning frame (via FrameLoader.)
71 //
72 // ProgressTracker is finalized by FrameLoader (which in turn is
73 // finalized by LocalFrame.) Its lifetime thus guarantees that
74 // m_frame cannot be used to access a dead LocalFrame.
75 //
76 // FIXME: Oilpan: tidy up and move ProgressTracker to the heap.
77 LocalFrame* m_frame;
78 bool m_inProgress; 72 bool m_inProgress;
79 long long m_totalPageAndResourceBytesToLoad; 73 long long m_totalPageAndResourceBytesToLoad;
80 long long m_totalBytesReceived; 74 long long m_totalBytesReceived;
81 double m_lastNotifiedProgressValue; 75 double m_lastNotifiedProgressValue;
82 double m_lastNotifiedProgressTime; 76 double m_lastNotifiedProgressTime;
83 double m_progressNotificationInterval; 77 double m_progressNotificationInterval;
84 double m_progressNotificationTimeInterval; 78 double m_progressNotificationTimeInterval;
85 bool m_finalProgressChangedSent; 79 bool m_finalProgressChangedSent;
86 double m_progressValue; 80 double m_progressValue;
87 81
88 HashMap<unsigned long, OwnPtr<ProgressItem> > m_progressItems; 82 HashMap<unsigned long, OwnPtr<ProgressItem> > m_progressItems;
89 }; 83 };
90 84
91 } 85 }
92 86
93 #endif 87 #endif
OLDNEW
« no previous file with comments | « Source/core/loader/MixedContentChecker.cpp ('k') | Source/core/loader/ProgressTracker.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698