Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Unified Diff: Source/core/loader/ProgressTracker.cpp

Issue 596653006: Have MixedContentChecker and ProgressTracker keep a LocalFrame Member. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/loader/ProgressTracker.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/loader/ProgressTracker.cpp
diff --git a/Source/core/loader/ProgressTracker.cpp b/Source/core/loader/ProgressTracker.cpp
index 3321625c2fc3bdb061b5e275217d5278ca96bb4b..eb6f20699d241ec0c6d38cdfeae5ad16ec18a631 100644
--- a/Source/core/loader/ProgressTracker.cpp
+++ b/Source/core/loader/ProgressTracker.cpp
@@ -62,6 +62,11 @@ public:
long long estimatedLength;
};
+PassOwnPtrWillBeRawPtr<ProgressTracker> ProgressTracker::create(LocalFrame* frame)
+{
+ return adoptPtrWillBeNoop(new ProgressTracker(frame));
+}
+
ProgressTracker::ProgressTracker(LocalFrame* frame)
: m_frame(frame)
, m_inProgress(false)
@@ -78,13 +83,18 @@ ProgressTracker::ProgressTracker(LocalFrame* frame)
ProgressTracker::~ProgressTracker()
{
- if (m_inProgress)
- progressCompleted();
+ ASSERT(!m_inProgress);
}
-PassOwnPtr<ProgressTracker> ProgressTracker::create(LocalFrame* frame)
+void ProgressTracker::trace(Visitor* visitor)
{
- return adoptPtr(new ProgressTracker(frame));
+ visitor->trace(m_frame);
+}
+
+void ProgressTracker::dispose()
+{
+ if (m_inProgress)
+ progressCompleted();
}
double ProgressTracker::estimatedProgress() const
« no previous file with comments | « Source/core/loader/ProgressTracker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698