Mixed Content: Make MixedContentChecker completely static.

Mixed Content: Make MixedContentChecker completely static.

This patch completes the transition away from MixedContentChecker as an
object with state, into a world where it just provides static methods.
This should clear up the interface, and make migration to RemoteFrame
a bit simpler.

After this patch, we no longer hang a MixedContentChecker object off
of FrameLoader, nor does MixedContentChecker need to hold a reference
to a frame. Everything we need to do the checks can be done by passing
values into the checker methods.

Note also that this patch deletes a number of expectation files: these
are testharness.js tests, which shouldn't have expectations
committed into the repository. Rather than modifying them, this patch
removes them.

As a drive-by, this also corrects the FormsSubmitted counter.
It ought to count all form submissions as "FormsSubmitted", and mixed
submissions as a subset thereof (e.g. 5 form submissions, 
with 2 of them mixed would result in FormsSubmitted: 5, 
MixedContentFormsSubmitted: 2, as opposed to the current 3 and 2).

BUG=411184
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181885

[Mike West, 2014-09-11 11:43:54]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org, philipj@opera.com, sigbjornf@opera.com

[Mike West, 2014-09-11 11:43:54]

Since you made the terrible mistake of actually reviewing a mixed content patch,
I'm sending you the next one too. :)

WDYT?

-mike

[Mike West, 2014-09-11 11:54:02]

+nasko@: FYI. Yay!

[jochen (gone - plz use gerrit), 2014-09-11 12:53:23]

lgtm

https://codereview.chromium.org/566533003/diff/1/Source/core/html/HTMLFormEle...
File Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/566533003/diff/1/Source/core/html/HTMLFormEle...
Source/core/html/HTMLFormElement.cpp:445: UseCounter::count(document(),
UseCounter::FormsSubmitted);
that changes the semantics of this use counter, no? is that on purpose?

[Mike West, 2014-09-11 13:10:40]

Thanks!

https://codereview.chromium.org/566533003/diff/1/Source/core/html/HTMLFormEle...
File Source/core/html/HTMLFormElement.cpp (right):

https://codereview.chromium.org/566533003/diff/1/Source/core/html/HTMLFormEle...
Source/core/html/HTMLFormElement.cpp:445: UseCounter::count(document(),
UseCounter::FormsSubmitted);
On 2014/09/11 12:53:23, jochen wrote:
> that changes the semantics of this use counter, no? is that on purpose?

Yes. I'll add a note to the CL description.

The current behavior counts mixed submissions and unmixed submissions
separately. I think the expected behavior is to count all form submissions as
"FormsSubmitted", and have mixed submissions be a subset thereof.

[Mike West, 2014-09-11 13:10:45]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-09-11 13:11:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566533003/1

[commit-bot: I haz the power, 2014-09-11 14:11:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 14:11:53]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...)

[Mike West, 2014-09-12 06:46:13]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-09-12 06:46:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/566533003/20001

[commit-bot: I haz the power, 2014-09-12 08:25:58]

Committed patchset #2 (id:20001) as 181885