Make "priv" classes for GrTexure and GrSurface.

Make "priv" classes for GrTexure and GrSurface.

Committed: https://skia.googlesource.com/skia/+/afbf2d6273cd22c683f20a7e5773843876af3085

[bsalomon, 2014-09-26 17:51:09]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, joshualitt@google.com, robertphillips@google.com

[bsalomon, 2014-09-26 17:51:10]

This is related to our discussion on Wednesday. This adds friend wrappers for
texture and surface that provide additional access. The new interfaces are in
src/gpu rather than include/gpu.

[bsalomon, 2014-09-27 14:01:28]

Patchset #1 (id:1) has been deleted

[bsalomon, 2014-09-27 14:01:40]

Patchset #1 (id:20001) has been deleted

[bsalomon, 2014-09-27 14:01:48]

Patchset #1 (id:40001) has been deleted

[bsalomon, 2014-09-27 14:01:56]

Patchset #1 (id:60001) has been deleted

[bsalomon, 2014-09-27 14:02:12]

Patchset #1 (id:80001) has been deleted

[robertphillips, 2014-09-29 13:34:28]

Mainly questions

https://codereview.chromium.org/596053002/diff/140001/include/gpu/GrTexture.h
File include/gpu/GrTexture.h (right):

https://codereview.chromium.org/596053002/diff/140001/include/gpu/GrTexture.h...
include/gpu/GrTexture.h:110: MipMapsStatus   fMipMapsStatus;
Preserve old comment if these are going to stay ?

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurface.cpp
File src/gpu/GrSurface.cpp (right):

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurface.cpp#n...
src/gpu/GrSurface.cpp:84: 
It looks like GrSurfacePriv is careful to leave all the implementation in
GrSurface and just expose the methods. GrTexturePriv, on the other hand, appears
to shoulder some of the implementation burden. Should we standardize on one
approach or the other?

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurfacePriv.h
File src/gpu/GrSurfacePriv.h (right):

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurfacePriv.h...
src/gpu/GrSurfacePriv.h:14: /** Class that adds methods to GrSurface that are
only intended for use internal to Skia. */
// It should never get additional member variables (besides the fSurface
pointer) or virtual functions.

?

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurfacePriv.h...
src/gpu/GrSurfacePriv.h:29: 
Should this be DEVELOPER only ?

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurfacePriv.h...
src/gpu/GrSurfacePriv.h:48: 
// For access to ctor. ?

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTextStrike.cpp
File src/gpu/GrTextStrike.cpp (right):

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTextStrike.cp...
src/gpu/GrTextStrike.cpp:209: #endif
Can savePixels be implemented as a static function here rather then in
GrSurface* ?

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexture.cpp
File src/gpu/GrTexture.cpp (right):

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexture.cpp#n...
src/gpu/GrTexture.cpp:44: 
Move the GrTexturePriv methods to a different .cpp ?

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexture.cpp#n...
src/gpu/GrTexture.cpp:47: if (GrTexture::kValid_MipMapsStatus ==
fTexture->fMipMapsStatus) {
stray ' '

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexture.cpp#n...
src/gpu/GrTexture.cpp:213: , fMipMapsStatus(kNotAllocated_MipMapsStatus) {
It seems a bit odd to have to access GrTexturePriv for ComputeScratchKey.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexturePriv.h
File src/gpu/GrTexturePriv.h (right):

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexturePriv.h...
src/gpu/GrTexturePriv.h:13: 
// A wrapper class that grants access to GrTexture's internals.
// It should never get additional member variables (besides the pointer to the
GrTexture) or virtual functions.

?

Should this be derived from GrSurfacePriv ?

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexturePriv.h...
src/gpu/GrTexturePriv.h:46: 
It seems like these two should be static functions somewhere else.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexturePriv.h...
src/gpu/GrTexturePriv.h:65: 
// For access to ctor, ComputeScratchKey.

?

[joshua.litt, 2014-09-29 13:58:08]

joshualitt@chromium.org changed reviewers:
+ joshualitt@chromium.org

[joshua.litt, 2014-09-29 13:58:09]

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurface.cpp
File src/gpu/GrSurface.cpp (right):

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurface.cpp#n...
src/gpu/GrSurface.cpp:84: 
On 2014/09/29 13:34:27, robertphillips wrote:
> It looks like GrSurfacePriv is careful to leave all the implementation in
> GrSurface and just expose the methods. GrTexturePriv, on the other hand,
appears
> to shoulder some of the implementation burden. Should we standardize on one
> approach or the other?

I think my preference is to move implementations of private methods to the *Priv
classes because it prevents these functions from cluttering up the public
interface, even if they are private.  It seems more pimpl to me.  Its also one
less level of indirection for these methods.

[bsalomon, 2014-09-29 18:42:11]

updated

https://codereview.chromium.org/596053002/diff/140001/include/gpu/GrTexture.h
File include/gpu/GrTexture.h (right):

https://codereview.chromium.org/596053002/diff/140001/include/gpu/GrTexture.h...
include/gpu/GrTexture.h:110: MipMapsStatus   fMipMapsStatus;
On 2014/09/29 13:34:27, robertphillips wrote:
> Preserve old comment if these are going to stay ?

Done.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurface.cpp
File src/gpu/GrSurface.cpp (right):

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurface.cpp#n...
src/gpu/GrSurface.cpp:84: 
On 2014/09/29 13:58:08, joshua.litt wrote:
> On 2014/09/29 13:34:27, robertphillips wrote:
> > It looks like GrSurfacePriv is careful to leave all the implementation in
> > GrSurface and just expose the methods. GrTexturePriv, on the other hand,
> appears
> > to shoulder some of the implementation burden. Should we standardize on one
> > approach or the other?
> 
> I think my preference is to move implementations of private methods to the
*Priv
> classes because it prevents these functions from cluttering up the public
> interface, even if they are private.  It seems more pimpl to me.  Its also one
> less level of indirection for these methods.

I don't feel strongly either way. The passthroughs are all inlined away. I do
like not having the clutter in the public .h so I guess I also lean towards impl
in the priv function.

However, for member functions that aren't trivially inlined I worry whether
compilers will wind up actually constructing the priv object if the method
called on it isn't inline.

I think the split might be: passthrough for complex methods, impl in priv for
inlines. Added a comment to that effect.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurfacePriv.h
File src/gpu/GrSurfacePriv.h (right):

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurfacePriv.h...
src/gpu/GrSurfacePriv.h:14: /** Class that adds methods to GrSurface that are
only intended for use internal to Skia. */
On 2014/09/29 13:34:27, robertphillips wrote:
> // It should never get additional member variables (besides the fSurface
> pointer) or virtual functions.
> 
> ?

Done.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurfacePriv.h...
src/gpu/GrSurfacePriv.h:29: 
On 2014/09/29 13:34:28, robertphillips wrote:
> Should this be DEVELOPER only ?

Maybe, let's leave that to a future CL. Added a comment at the impl.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrSurfacePriv.h...
src/gpu/GrSurfacePriv.h:48: 
On 2014/09/29 13:34:27, robertphillips wrote:
> // For access to ctor. ?

Done.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTextStrike.cpp
File src/gpu/GrTextStrike.cpp (right):

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTextStrike.cp...
src/gpu/GrTextStrike.cpp:209: #endif
On 2014/09/29 13:34:28, robertphillips wrote:
> Can savePixels be implemented as a static function here rather then in
> GrSurface* ?

Surely, but I'd rather just mark as a TODO. This change only makes it harder to
access this function.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexture.cpp
File src/gpu/GrTexture.cpp (right):

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexture.cpp#n...
src/gpu/GrTexture.cpp:44: 
On 2014/09/29 13:34:28, robertphillips wrote:
> Move the GrTexturePriv methods to a different .cpp ?

Since the Privs only operate on the data of the non-Privs, they feel like just
an alternate interface to the same class. And the files are short. I prefer them
to be in the same cpp to make it make it easier to see all the uses of the data
fields of the non-priv in one place. I'm not strongly opposed to splitting them
out, though.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexture.cpp#n...
src/gpu/GrTexture.cpp:47: if (GrTexture::kValid_MipMapsStatus ==
fTexture->fMipMapsStatus) {
On 2014/09/29 13:34:28, robertphillips wrote:
> stray ' '

Done.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexture.cpp#n...
src/gpu/GrTexture.cpp:213: , fMipMapsStatus(kNotAllocated_MipMapsStatus) {
On 2014/09/29 13:34:28, robertphillips wrote:
> It seems a bit odd to have to access GrTexturePriv for ComputeScratchKey.

This has to be called outside of GrTexture(Priv) and I don't think we want it as
a public on GrTexture, it seems firmly on the Priv/Ganesh-internal side of the
fence. So, open to other ideas, but I'm not sure what else to do.

I think of GrTexture and GrTexturePriv as really the same class but split apart
since there isn't such a thing as package-level privacy in the language.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexturePriv.h
File src/gpu/GrTexturePriv.h (right):

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexturePriv.h...
src/gpu/GrTexturePriv.h:13: 
On 2014/09/29 13:34:28, robertphillips wrote:
> // A wrapper class that grants access to GrTexture's internals.
> // It should never get additional member variables (besides the pointer to the
> GrTexture) or virtual functions.
> 
> ?
> 
> Should this be derived from GrSurfacePriv ?

Done.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexturePriv.h...
src/gpu/GrTexturePriv.h:46: 
On 2014/09/29 13:34:28, robertphillips wrote:
> It seems like these two should be static functions somewhere else.

Agreed, will mark as TODO.

https://codereview.chromium.org/596053002/diff/140001/src/gpu/GrTexturePriv.h...
src/gpu/GrTexturePriv.h:65: 
On 2014/09/29 13:34:28, robertphillips wrote:
> // For access to ctor, ComputeScratchKey.
> 
> ?

first yes, CSK is already public.

[robertphillips, 2014-09-29 19:22:00]

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrDistanceField...
File src/gpu/GrDistanceFieldTextContext.cpp (right):

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrDistanceField...
src/gpu/GrDistanceFieldTextContext.cpp:20: #include "SkDistanceFieldGen.h"
out of order ?

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrSurfacePriv.h
File src/gpu/GrSurfacePriv.h (right):

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrSurfacePriv.h...
src/gpu/GrSurfacePriv.h:14: /** Class that adds methods to GrSurface that are
only intended for use internal to Skia.
privileged

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrTexture.cpp
File src/gpu/GrTexture.cpp (right):

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrTexture.cpp#n...
src/gpu/GrTexture.cpp:44: 
Doesn't this need to get springboarded?

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrTexturePriv.h
File src/gpu/GrTexturePriv.h (right):

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrTexturePriv.h...
src/gpu/GrTexturePriv.h:14: /** Class that adds methods to GrTexture that are
only intended for use internal to Skia.
privileged

[bsalomon, 2014-09-29 19:46:29]

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrDistanceField...
File src/gpu/GrDistanceFieldTextContext.cpp (right):

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrDistanceField...
src/gpu/GrDistanceFieldTextContext.cpp:20: #include "SkDistanceFieldGen.h"
On 2014/09/29 19:21:59, robertphillips wrote:
> out of order ?

Done.

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrSurfacePriv.h
File src/gpu/GrSurfacePriv.h (right):

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrSurfacePriv.h...
src/gpu/GrSurfacePriv.h:14: /** Class that adds methods to GrSurface that are
only intended for use internal to Skia.
On 2014/09/29 19:21:59, robertphillips wrote:
> privileged

Done.

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrTexture.cpp
File src/gpu/GrTexture.cpp (right):

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrTexture.cpp#n...
src/gpu/GrTexture.cpp:44: 
On 2014/09/29 19:21:59, robertphillips wrote:
> Doesn't this need to get springboarded?

Do'h. Done.

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrTexturePriv.h
File src/gpu/GrTexturePriv.h (right):

https://codereview.chromium.org/596053002/diff/160001/src/gpu/GrTexturePriv.h...
src/gpu/GrTexturePriv.h:14: /** Class that adds methods to GrTexture that are
only intended for use internal to Skia.
On 2014/09/29 19:22:00, robertphillips wrote:
> privileged

Done.

[robertphillips, 2014-09-29 20:01:35]

lgtm + a nit

https://codereview.chromium.org/596053002/diff/180001/src/gpu/GrTexture.cpp
File src/gpu/GrTexture.cpp (right):

https://codereview.chromium.org/596053002/diff/180001/src/gpu/GrTexture.cpp#n...
src/gpu/GrTexture.cpp:47: if (kValid_MipMapsStatus == fMipMapsStatus) {
Shouldn't need these GrTexture's anymore.

[bsalomon, 2014-09-29 20:03:05]

https://codereview.chromium.org/596053002/diff/180001/src/gpu/GrTexture.cpp
File src/gpu/GrTexture.cpp (right):

https://codereview.chromium.org/596053002/diff/180001/src/gpu/GrTexture.cpp#n...
src/gpu/GrTexture.cpp:47: if (kValid_MipMapsStatus == fMipMapsStatus) {
On 2014/09/29 20:01:34, robertphillips wrote:
> Shouldn't need these GrTexture's anymore.

nice catch, will delete.

[bsalomon, 2014-09-29 20:07:55]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-09-29 20:08:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596053002/200001

[commit-bot: I haz the power, 2014-09-29 20:09:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 20:09:03]

Failed to apply patch for src/gpu/GrContext.cpp:
While running git apply --index -3 -p1;
  error: patch failed: src/gpu/GrContext.cpp:1712
  Falling back to three-way merge...
  Applied patch to 'src/gpu/GrContext.cpp' with conflicts.
  U src/gpu/GrContext.cpp

Patch:       src/gpu/GrContext.cpp
Index: src/gpu/GrContext.cpp
diff --git a/src/gpu/GrContext.cpp b/src/gpu/GrContext.cpp
index
ad1b4c49553316267a5ed150390f8e68ed47cb7d..4d9fc5b54d28da1c8e3b853076649391d37b5153
100755
--- a/src/gpu/GrContext.cpp
+++ b/src/gpu/GrContext.cpp
@@ -30,7 +30,9 @@
 #include "GrStencilBuffer.h"
 #include "GrStencilAndCoverTextContext.h"
 #include "GrStrokeInfo.h"
+#include "GrSurfacePriv.h"
 #include "GrTextStrike.h"
+#include "GrTexturePriv.h"
 #include "GrTraceMarker.h"
 #include "GrTracing.h"
 #include "SkDashPathPriv.h"
@@ -68,6 +70,25 @@ static const int DRAW_BUFFER_IBPOOL_PREALLOC_BUFFERS = 4;
 
 #define ASSERT_OWNED_RESOURCE(R) SkASSERT(!(R) || (R)->getContext() == this)
 
+GrTexture* GrAutoScratchTexture::detach() {
+    if (NULL == fTexture) {
+        return NULL;
+    }
+    GrTexture* texture = fTexture;
+    fTexture = NULL;
+
+    // This GrAutoScratchTexture has a ref from lockAndRefScratchTexture, which
we give up now.
+    // The cache also has a ref which we are lending to the caller of detach().
When the caller
+    // lets go of the ref and the ref count goes to 0 internal_dispose will see
this flag is
+    // set and re-ref the texture, thereby restoring the cache's ref.
+    SkASSERT(!texture->unique());
+    texture->texturePriv().setFlag((GrTextureFlags)
GrTexture::kReturnToCache_FlagBit);
+    texture->unref();
+    SkASSERT(texture->getCacheEntry());
+
+    return texture;
+}
+
 // Glorified typedef to avoid including GrDrawState.h in GrContext.h
 class GrContext::AutoRestoreEffects : public GrDrawState::AutoRestoreEffects
{};
 
@@ -262,7 +283,7 @@ GrTextContext* GrContext::createTextContext(GrRenderTarget*
renderTarget,
 GrTexture* GrContext::findAndRefTexture(const GrTextureDesc& desc,
                                         const GrCacheID& cacheID,
                                         const GrTextureParams* params) {
-    GrResourceKey resourceKey = GrTextureImpl::ComputeKey(fGpu, params, desc,
cacheID);
+    GrResourceKey resourceKey = GrTexturePriv::ComputeKey(fGpu, params, desc,
cacheID);
     GrGpuResource* resource = fResourceCache->find(resourceKey);
     SkSafeRef(resource);
     return static_cast<GrTexture*>(resource);
@@ -271,7 +292,7 @@ GrTexture* GrContext::findAndRefTexture(const GrTextureDesc&
desc,
 bool GrContext::isTextureInCache(const GrTextureDesc& desc,
                                  const GrCacheID& cacheID,
                                  const GrTextureParams* params) const {
-    GrResourceKey resourceKey = GrTextureImpl::ComputeKey(fGpu, params, desc,
cacheID);
+    GrResourceKey resourceKey = GrTexturePriv::ComputeKey(fGpu, params, desc,
cacheID);
     return fResourceCache->hasKey(resourceKey);
 }
 
@@ -410,16 +431,16 @@ GrTexture* GrContext::createTexture(const GrTextureParams*
params,
                                     const void* srcData,
                                     size_t rowBytes,
                                     GrResourceKey* cacheKey) {
-    GrResourceKey resourceKey = GrTextureImpl::ComputeKey(fGpu, params, desc,
cacheID);
+    GrResourceKey resourceKey = GrTexturePriv::ComputeKey(fGpu, params, desc,
cacheID);
 
     GrTexture* texture;
-    if (GrTextureImpl::NeedsResizing(resourceKey)) {
+    if (GrTexturePriv::NeedsResizing(resourceKey)) {
         // We do not know how to resize compressed textures.
         SkASSERT(!GrPixelConfigIsCompressed(desc.fConfig));
 
         texture = this->createResizedTexture(desc, cacheID,
                                              srcData, rowBytes,
-                                            
GrTextureImpl::NeedsBilerp(resourceKey));
+                                            
GrTexturePriv::NeedsBilerp(resourceKey));
     } else {
         texture = fGpu->createTexture(desc, srcData, rowBytes);
     }
@@ -443,7 +464,7 @@ static GrTexture* create_scratch_texture(GrGpu* gpu,
                                          const GrTextureDesc& desc) {
     GrTexture* texture = gpu->createTexture(desc, NULL, 0);
     if (texture) {
-        GrResourceKey key = GrTextureImpl::ComputeScratchKey(texture->desc());
+        GrResourceKey key = GrTexturePriv::ComputeScratchKey(texture->desc());
         // Adding a resource could put us overbudget. Try to free up the
         // necessary space before adding it.
         resourceCache->purgeAsNeeded(1, texture->gpuMemorySize());
@@ -483,7 +504,7 @@ GrTexture* GrContext::lockAndRefScratchTexture(const
GrTextureDesc& inDesc, Scra
     int origHeight = desc.fHeight;
 
     do {
-        GrResourceKey key = GrTextureImpl::ComputeScratchKey(desc);
+        GrResourceKey key = GrTexturePriv::ComputeScratchKey(desc);
         // Ensure we have exclusive access to the texture so future 'find'
calls don't return it
         resource = fResourceCache->find(key,
GrResourceCache::kHide_OwnershipFlag);
         if (resource) {
@@ -578,7 +599,7 @@ void GrContext::unlockScratchTexture(GrTexture* texture) {
             // Instead, give up the cache's ref and leave the decision up to
             // addExistingTextureToCache once its ref count reaches 0. For
             // this to work we need to leave it in the exclusive list.
-            texture->impl()->setFlag((GrTextureFlags)
GrTextureImpl::kReturnToCache_FlagBit);
+            texture->texturePriv().setFlag((GrTextureFlags)
GrTexture::kReturnToCache_FlagBit);
             // Give up the cache's ref to the texture
             texture->unref();
         }
@@ -1347,7 +1368,7 @@ bool GrContext::writeTexturePixels(GrTexture* texture,
         }
     }
 
-    if (!(kDontFlush_PixelOpsFlag & flags) && texture->hasPendingIO()) {
+    if (!(kDontFlush_PixelOpsFlag & flags) &&
texture->surfacePriv().hasPendingIO()) {
         this->flush();
     }
 
@@ -1418,7 +1439,7 @@ bool GrContext::readRenderTargetPixels(GrRenderTarget*
target,
         }
     }
 
-    if (!(kDontFlush_PixelOpsFlag & flags) && target->hasPendingWrite()) {
+    if (!(kDontFlush_PixelOpsFlag & flags) &&
target->surfacePriv().hasPendingWrite()) {
         this->flush();
     }
 
@@ -1712,7 +1733,7 @@ bool GrContext::writeRenderTargetPixels(GrRenderTarget*
target,
     // drawing a rect). So we always draw directly to GrGpu and preserve the
current geometry.
     // But that means we also have to flush the draw buffer if there is a
pending IO operation to
     // the render target.
-    if (!(kDontFlush_PixelOpsFlag & flags) && target->hasPendingIO()) {
+    if (!(kDontFlush_PixelOpsFlag & flags) &&
target->surfacePriv().hasPendingIO()) {
         this->flush();
     }
     SkMatrix matrix;

[bsalomon, 2014-09-29 20:14:39]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-09-29 20:15:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596053002/220001

[commit-bot: I haz the power, 2014-09-29 20:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-29 20:18:26]

Try jobs failed on following builders:
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Andr...)

[bsalomon, 2014-09-29 21:06:34]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-09-29 21:07:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596053002/240001

[bsalomon, 2014-09-29 21:09:10]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2014-09-29 21:11:18]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-09-29 21:12:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596053002/260001

[commit-bot: I haz the power, 2014-09-29 21:20:15]

Committed patchset #9 (id:260001) as c0eb9b9818462471f5fc1c47fa549c6052d8bbae

[robertphillips, 2014-09-30 13:57:11]

A revert of this CL (patchset #9 id:260001) has been created in
https://codereview.chromium.org/618733002/ by robertphillips@google.com.

The reason for reverting is: Breaking the Chrome builds with:

 lib/libcc.so: error: undefined reference to 'GrAutoScratchTexture::detach()'

(http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-...).

[bsalomon, 2014-09-30 19:04:35]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-09-30 19:05:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/596053002/280001

[commit-bot: I haz the power, 2014-09-30 19:18:48]

Committed patchset #10 (id:280001) as afbf2d6273cd22c683f20a7e5773843876af3085